Skip to content

[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM #49497

Closed
#49500
Closed
[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM#49497
#49500
Labels
confirmed-bugIssues and PRs for confirmed bugs.esmIssues and PRs related to the ECMAScript Modules implementation.moduleIssues and PRs related to the module subsystem.

Description

@liuxingbaoyu
liuxingbaoyu
opened on Sep 5, 2023

Version

v20.6.0

Platform

all

Subsystem

No response

What steps will reproduce the bug?

https://github.com/liuxingbaoyu/node-v20.6-bug

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

node .\main.js
run
success

What do you see instead?

node .\main.js
run
run
success

Additional information

This should be the regression introduced by v20.6.

Activity

  1. liuxingbaoyu
    changed the title [-][v20.6] CJS cycle dependency throwing error is loaded by ESM[/-] [+][v20.6] CJS cycle dependencies throw an error when being loaded by ESM[/+] on Sep 5, 2023
  2. liuxingbaoyu
    changed the title [-][v20.6] CJS cycle dependencies throw an error when being loaded by ESM[/-] [+][v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM[/+] on Sep 5, 2023
  3. kunish
    added a commit that references this issue on Sep 5, 2023

    fix: build issue, `Cannot redefine property: File`

    b50c41e
  4. matz3
    added a commit that references this issue on Sep 5, 2023

    [INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    2e06f6b

  5. nicolo-ribaudo commented on Sep 5, 2023

    @nicolo-ribaudo
    nicolo-ribaudo
    on Sep 5, 2023
    Contributor

    Note that this is breaking@babel/core, and thus all the frameworks/project that use it. It would be great to prioritize it 🙏

  6. targos commented on Sep 5, 2023

    @targos
    targos
    on Sep 5, 2023
    Member

    Can someone give a reproducible example? The code from https://github.com/liuxingbaoyu/node-v20.6-bug doesn't show the problem (it throws an error in mod/index.js).

  7. liuxingbaoyu commented on Sep 5, 2023

    @liuxingbaoyu
    liuxingbaoyu
    on Sep 5, 2023
    ContributorAuthor

    Sorry, I forgot to push the second commit.
    But the initial error is also different due to the regression.

  8. liuxingbaoyu commented on Sep 5, 2023

    @liuxingbaoyu
    liuxingbaoyu
    on Sep 5, 2023
    ContributorAuthor

    Please try again, thanks!

  9. nicolo-ribaudo commented on Sep 5, 2023

    @nicolo-ribaudo
    nicolo-ribaudo
    on Sep 5, 2023 · Hidden as outdated

  10. nicolo-ribaudo commented on Sep 5, 2023

    @nicolo-ribaudo
    nicolo-ribaudo
    on Sep 5, 2023
    Contributor

    A minimal reproduction:

    // index.mjs
import "./dep.cjs";
    // dep.cjs
require("./dep.cjs");
console.log("RUNNING");

    Running node index.mjs logs twice but it should log once.

  11. targos commented on Sep 5, 2023

    @targos
    targos
    on Sep 5, 2023
    Member

    I have a repro. Starting to bisect.

  12. matz3
    added 2 commits that reference this issue on Sep 5, 2023

    [INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    83fae6c

    [INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    98672ae

  13. nicolo-ribaudo commented on Sep 5, 2023

    @nicolo-ribaudo
    nicolo-ribaudo
    on Sep 5, 2023
    Contributor

    @targos If it helps, it looks like the problem is that ESM's CJS loader doesn't set this loaded = true before evaluating the CJS module.

    Here probably:

    node/lib/internal/modules/esm/translators.js

    Line 326 in 5b31ff1

    cjsParseCache.set(module, { source, exportNames });

  14. targos commented on Sep 5, 2023

    @targos
    targos
    on Sep 5, 2023
    Member

    Bug is introduced by #47999

  15. 44 remaining items

  16. d3xter666
    added 7 commits that reference this issue on Sep 24, 2025

    [ui5-logger][INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    6889336

    [ui5-logger][ui5-logger][INTERNAL] Azure Pipelines: Switch back to No…

    73a3bdb

    [ui5-project][INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    6541161

    [ui5-cli][INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    6813dd4

    [project][INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    2958b45

    [cli][INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    c855585

    [cli][INTERNAL] Azure Pipelines: Switch back to Node 20.5.x

    987d052
  17. serhalp
    added a commit that references this issue on Jan 30, 2026

    feat!: drop Node.js 18 support, require >=20.6.1

    87eb7f0
  18. serhalp
    added a commit that references this issue on Feb 25, 2026

    feat!: drop Node.js 18 support, require >=20 (#623)

    dc9c499
  19. kriscendobot
    added a commit that references this issue on May 18, 2026

    ci: preserve Node 20 SES-viable patch history (per kriskowal review on …

    c040dc7
  20. kriskowal
    added a commit that references this issue on May 18, 2026

    chore(ci): drop Node.js 20 from the test matrix

    6d007fa
  21. turadg
    added 3 commits that reference this issue on May 20, 2026

    chore(ci): drop Node.js 20 from the test matrix

    e385d46

    chore(ci): drop Node.js 20 from the test matrix

    790984b

    chore(ci): drop Node.js 20 from the test matrix

    6cfec20
  22. filipkunc
    added a commit that references this issue on Jul 22, 2026

    Remove the Frida/detours approach

    064c634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.esmIssues and PRs related to the ECMAScript Modules implementation.moduleIssues and PRs related to the module subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions