Skip to content

v8-updates/test-linux-perf.js is flaky #48861

Closed as not planned
Closed as not planned

Description

@joyeecheung

Example error: https://ci.nodejs.org/job/node-test-commit-v8-linux/5468/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console

I wonder if we actually need to check the output of perf script - IIUC we are just checking that linux perf can produce maps for both interpreted and compiled functions. In this case simply checking the perf map should be enough (as long as the mappings are produced, they should appear). Checking the output of perf script may not be robust enough unless we tweak the how the functions are sampled very carefully (but it can still depend a lot on the state of the machine).

Activity

  1. joyeecheung commented on Jul 20, 2023

    @joyeecheung
    MemberAuthor

    Another idea: maybe the lack of interpreted frames was caused by the function being compiled by maglev/sparkplug (--no-opt is only an alias for --no-turbofan), setting it to --max-opt=0 may be more robust

  2. added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Jul 26, 2023
  3. github-actions commented on May 30, 2026

    @github-actions
    Contributor

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  4. added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on May 30, 2026
  5. github-actions commented on Jun 29, 2026

    @github-actions
    Contributor

    This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 240 days).
    If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions