You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Incosistant result between test and it in node:test #48582
Activity
aduh95 commentedon Jun 28, 2023
Can you share code and copy/paste output rather than a video? Videos take more bandwidth and are not very helpful for folks with visual disabilities.
atlowChemi commentedon Jun 28, 2023
I believe this has been fixed on newer Node versions: #46889
cjihrig commentedon Jun 29, 2023
I agree it looks like it should be fixed. It looks like that change was backported in the 18.16.0 release, but this bug report is for 18.16.0.
EDIT: Looking at the backport commit I see that the added doc metadata says 18.6.0 instead of 18.16.0, so it's possible something went wrong.
himself65 commentedon Jun 29, 2023
This is copy video from my colleague, and I confirm that he's node.js
18.15.0. And I double-checked that it works well in18.16.0.And the way to reproduce it is to replace
itwithtest(code https://github.com/toeverything/AFFiNE/blob/2c95bfcc3dfe0dfbeee39254f80a6f4760fb67b8/apps/server/src/tests/workspace.spec.ts#L2)Since I also believe it has been fixed. I won't give the minimum reproduction code.
himself65 commentedon Jun 29, 2023
I think it's correct. because it did land in 18.6.0 first (#43420). My issue typed wrong version