Skip to content

Backport ESM loader changes to 18.x #48042

Closed
Closed
Backport ESM loader changes to 18.x#48042
Labels
esmIssues and PRs related to the ECMAScript Modules implementation.feature requestIssues requesting new Node.js features.loadersIssues and PRs related to ES module loaders.

Description

@bencmbrook
bencmbrook
opened on May 16, 2023

What is the problem this feature will solve?

Pulling this request (#43772 (comment)) into its own Issue.

This would allow chaining loaders in Node 18.x (and unlock many Yarn PnP use-cases without having to wait for 20.x LTS)

What is the feature you are proposing to solve the problem?

Backport the changes related to "ESM: Leverage loaders when resolving subsequent loaders".

What alternatives have you considered?

No response

Activity

  1. bencmbrook
    added
    feature requestIssues requesting new Node.js features.
    on May 16, 2023
  2. github-project-automation
    added this to Node.js feature requestson May 16, 2023
  3. github-project-automation
    moved this to Pending Triage in Node.js feature requestson May 16, 2023
  4. VoltrexKeyva
    added
    esmIssues and PRs related to the ECMAScript Modules implementation.
    loadersIssues and PRs related to ES module loaders.
    on May 17, 2023

  5. aduh95 commented on May 18, 2023

    @aduh95
    aduh95
    on May 18, 2023
    Contributor

    Did you check the backporting guide?

    node/doc/contributing/backporting-to-release-lines.md

    Lines 11 to 25 in a0440c9

    ## What needs to be backported?
    If a cherry-pick from `main` does not land cleanly on a staging branch, the
    releaser will mark the pull request with a particular label for that release
    line (e.g. `backport-requested-vN.x`), specifying to our tooling that this
    pull request should not be included. The releaser will then add a comment
    requesting that a backport pull request be made.
    ## What can be backported?
    The "Current" release line is much more lenient than the LTS release lines in
    what can be landed. Our LTS release lines (see the [Release Plan][])
    require that commits mature in the Current release for at least 2 weeks before
    they can be landed in an LTS staging branch. Only after "maturation" will those
    commits be cherry-picked or backported.

    TL;DR all commits that have landed on a current release branch will be backported "automatically" to the active LTS branches after a maturation period. If the commit doesn't land cleanly, the person preparing the release will add a comment to the PR asking for a manual backport.

    v18.x is an active LTS release line at the time of writing, see the Release Schedule.

  6. aduh95
    closed this as completedon May 18, 2023

  7. lizthegrey commented on May 20, 2023

    @lizthegrey
    lizthegrey
    on May 20, 2023

    @aduh95 the PR in question had dont-land-on-v18.x previously, which may have broken the automation because it was previously skipped. it's now set to requested backport.

  8. bencmbrook commented on May 24, 2023

    @bencmbrook
    bencmbrook
    on May 24, 2023
    Author

    @aduh95 should this be reopened given the above comment from @lizthegrey ?

  9. lizthegrey commented on Jul 20, 2023

    @lizthegrey
    lizthegrey
    on Jul 20, 2023

    This PR was not in fact backported via the usual automated means into Node 18.17.0 LTS last week. We request re-opening this issue since the automation has not backported it automatically. @aduh95 @MoLow @arcanis @bencmbrook

  10. aduh95 commented on Jul 20, 2023

    @aduh95
    aduh95
    on Jul 20, 2023
    Contributor

    To be clear, there are no automations in place, the process is very much manual: the volunteer for the LTS release will cherry-pick all the commits that have landed in v20.x – except the ones who do not land cleanly, and/or have a dont-land-on-v18.x or backport-requested-v18.x label on their associated PR.
    I'm not sure I see the point of reopening this issue, it would be redundant with the backport-requested-v18.x label; what is needed here is someone to contribute a backport PR, and I'm doubtful that having an open issue will make that more likely.

  11. lizthegrey commented on Jul 20, 2023

    @lizthegrey
    lizthegrey
    on Jul 20, 2023

    Oh! That clarifies a lot about how this PR got missed, and now that it's clear that contributing a backport PR is what's required, I can certainly have a go at it.

  12. lizthegrey commented on Nov 12, 2023

    @lizthegrey
    lizthegrey
    on Nov 12, 2023

    490b598 Backport has now been landed, thx @arcanis and @targos

  13. avivkeller
    removed this from Node.js feature requestson Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    esmIssues and PRs related to the ECMAScript Modules implementation.feature requestIssues requesting new Node.js features.loadersIssues and PRs related to ES module loaders.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions