SIGINT not triggering with readline #4758

Activity

1. evanlucas commented on Jan 19, 2016

   

   evanlucas

   on Jan 19, 2016

   Contributor

   More actions

   Hi @felipenmoura. Thanks for the report. Could you possibly give us a reduced test case with no external dependencies that shows this behavior so we can reproduce? Thanks!
2. r-52

   added

   readlineIssues and PRs related to the built-in readline module.Issues and PRs related to the built-in readline module.

   on Jan 19, 2016
3. Fishrock123 commented on Jan 19, 2016

   

   Fishrock123

   on Jan 19, 2016

   Contributor

   More actions

   @felipenmoura If you are trying to trigger by ctrl+C, that won't work, because readline catches the keys?

   👍React with 👍1Reacted by electrovir
4. Fishrock123

   added

   unconfirmed

   on Jan 19, 2016
5. felipenmoura commented on Jan 22, 2016

   

   felipenmoura

   on Jan 22, 2016

   Author

   More actions

   Yep.
   That's what is happening.
   It's being discussed in Inquirer.js, here: SBoudrias/Inquirer.js#293 (comment)
   Inquirer uses realine internally, therefore, who uses it cannot catch the SIGINT!

   By the way, a test case:

   process.on('SIGINT', function(){
       console.log('oh, you triggered it!');
   });
   
   const readline = require('readline');
   
   const rl = readline.createInterface({
       input: process.stdin,
       output: process.stdout
   });
   
   rl.question('What do you think of Node.js? ', (answer) => {
       console.log('Thank you for your valuable feedback, which was:\n', answer);
       rl.close();
   });

   👍React with 👍2Reacted by D.C. Rockwell and Gaurav Singh
6. Fishrock123

   added

   wontfixIssues that will not be fixed.Issues that will not be fixed.

   and removed

   unconfirmed

   on Jan 22, 2016
7. Fishrock123 commented on Jan 22, 2016

   

   Fishrock123

   on Jan 22, 2016

   Contributor

   More actions

   So, readline is actually handles it, but only if it thinks it's input is a TTY: https://github.com/nodejs/node/blob/master/lib/readline.js#L693-L701
8. Fishrock123

   added

   unconfirmed

   and removed

   wontfixIssues that will not be fixed.Issues that will not be fixed.

   on Jan 22, 2016
9. addaleax commented on Jul 7, 2016

   

   addaleax

   on Jul 7, 2016

   Member

   More actions

   Adding the SIGINT listener on the readline instance itself instead of process should work?

   👍React with 👍10Reacted by D.C. Rockwell, Titouan Teyssier, Tom, Doug Day, Christian Tapia, Sergey Lubeckiy, Joakim L. Christiansen, electrovir, Eric Eastwood and Rom
10. bnoordhuis commented on Oct 7, 2016

    

    bnoordhuis

    on Oct 7, 2016

    Member

    More actions

    This looks to have been solved for some time now so I'll go ahead and close the issue. Holler if it should be reopened.
11. bnoordhuis

    closed this as completedon Oct 7, 2016
12. harrysarson

    added a commit that references this issue on Jan 21, 2019

    Quit on cntl-c

    ...

    aa07159