Add CloseEvent #46880

Activity

1. regseb

   added

   feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.

   on Feb 28, 2023
2. debadree25

   added

   eventsIssues and PRs related to EventEmitter and the events module.Issues and PRs related to EventEmitter and the events module.

   on Feb 28, 2023
3. bnoordhuis commented on Feb 28, 2023

   

   bnoordhuis

   on Feb 28, 2023

   Member

   More actions

   I'm inclined to say exporting CloseEvent doesn't make sense because it's a websockets things, something node doesn't support natively.

   👍React with 👍2Reacted by Debadree Chatterjee and Sébastien Règne
4. regseb commented on Feb 28, 2023

   

   regseb

   on Feb 28, 2023

   Last edited by regseb

   ContributorAuthor

   More actions

   I thought WebSockets were implemented in Node. I use mock-socket which automatically adds the WebSocket class to the global scope, but not CloseEvent.

   I agree to add CloseEvent when Node will support WebSocket. There is already an issue #19308 for adding WebSockets. And nodejs/undici#1795 already implements it, but it doesn't export CloseEvent https://github.com/nodejs/undici/pull/1795/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346:

       module.exports.getGlobalOrigin = getGlobalOrigin
     }
   
   + if (nodeMajor >= 18) {
   +   const { WebSocket } = require('./lib/websocket/websocket')
   +
   +   module.exports.WebSocket = WebSocket
   + }
   +
     module.exports.request = makeDispatcher(api.request)
     module.exports.stream = makeDispatcher(api.stream)
     module.exports.pipeline = makeDispatcher(api.pipeline)
5. bnoordhuis commented on Mar 1, 2023

   

   bnoordhuis

   on Mar 1, 2023

   Member

   More actions

   I'll close this then. It's something we can revisit if and when node implements websockets.
6. bnoordhuis

   closed this as not plannedon Mar 1, 2023