Skip to content

repl: preview removed when press ESC key #46876

Closed
#46878
Closed
repl: preview removed when press ESC key#46876
#46878
Labels
replIssues and PRs related to the REPL subsystem.

Description

@jenthone
jenthone
opened on Feb 28, 2023

Version

18.12.1

Platform

Darwin 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64 x86_64

Subsystem

repl

What steps will reproduce the bug?

In repl

> 1+1 // then press ESC key

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Keep preview, only remove autocomplete

ChromeDevTools also keep the preview after pressing the ESC key
Chrome

What do you see instead?

The preview is removed

Additional information

The preview is removed by this PR: #42053

Activity

  1. VoltrexKeyva
    added
    replIssues and PRs related to the REPL subsystem.
    on Mar 1, 2023
  2. meixg
    added a commit that references this issue on Mar 3, 2023

    repl: preserve preview on ESCAPE key press

    90c08fe
  3. nodejs-github-bot
    closed this as completedin #46878on Mar 16, 2023
  4. nodejs-github-bot
    added a commit that references this issue on Mar 16, 2023

    repl: preserve preview on ESCAPE key press

    2566400
  5. targos
    added a commit that references this issue on Mar 18, 2023

    repl: preserve preview on ESCAPE key press

    d6a1232
  6. danielleadams
    added a commit that references this issue on Jul 6, 2023

    repl: preserve preview on ESCAPE key press

    e668efa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    replIssues and PRs related to the REPL subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions