parallel/test-repl-pretty-stack & parallel/test-repl-pretty-custom-stack assert the exact error message coming from V8 #43676

Activity

1. BridgeAR commented on Jul 4, 2022

   

   BridgeAR

   on Jul 4, 2022

   Member

   More actions

   @marjakh it should be fine to update the tests to only match for the Unexpected identifier:

   --- a/test/parallel/test-repl-pretty-stack.js
   +++ b/test/parallel/test-repl-pretty-stack.js
   @@ -26,10 +26,17 @@ function run({ command, expected, ...extraREPLOptions }, i) {
    
      r.write(`${command}\n`);
      console.log(i);
   -  assert.strictEqual(
   -    accum.replace(stackRegExp, '$1*:*'),
   -    expected.replace(stackRegExp, '$1*:*')
   -  );
   +  if (typeof expected === 'string') {
   +    assert.strictEqual(
   +      accum.replace(stackRegExp, '$1*:*'),
   +      expected.replace(stackRegExp, '$1*:*')
   +    );
   +  } else {
   +    assert.match(
   +      accum.replace(stackRegExp, '$1*:*'),
   +      expected
   +    );
   +  }
      r.close();
    }
    
   @@ -43,8 +50,7 @@ const tests = [
      },
      {
        command: 'let x y;',
   -    expected: 'let x y;\n      ^\n\n' +
   -              'Uncaught SyntaxError: Unexpected identifier\n'
   +    expected: /^let x y;\n {6}\^\n\nUncaught SyntaxError: .*Unexpected identifier\n/
      },
      {
        command: 'throw new Error(\'Whoops!\')',
2. targos

   added

   errorsIssues and PRs related to JavaScript errors originating in Node.js core.Issues and PRs related to JavaScript errors originating in Node.js core.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.

   on Jul 4, 2022
3. targos commented on Jul 18, 2022

   

   targos

   on Jul 18, 2022

   Member

   More actions

   @BridgeAR would you like to prepare a PR? Otherwise I can start from the diff you posted and do it. There's an example of the test failures with the new V8 in https://ci.nodejs.org/job/node-test-commit-linuxone/33075/
4. targos commented on Jul 25, 2022

   

   targos

   on Jul 25, 2022

   Member

   More actions

   Fixed on canary-base. Thanks for reporting!
5. targos

   closed this as completedon Jul 25, 2022
6. BridgeAR commented on Jul 25, 2022

   

   BridgeAR

   on Jul 25, 2022

   Member

   More actions

   @targos thanks for doing that! I missed your comment before.