Node.js 12.x need to cherry-pick https://github.com/nodejs/node/pull/37616 #42376

Activity

1. yisibl commented on Mar 17, 2022

   

   yisibl

   on Mar 17, 2022

   Last edited by yisibl

   More actions

   I have written a 100% reproducible case here: yisibl/svg-sprite#3

   > mocha "test/**/*.test.js"
   
     calculateSvgDimensions
       ✔ should return the expected dimensions from 46x46 fixture
   
     1 passing (41ms)
   
   [1]    10147 segmentation fault  npm test
2. richardlau

   added

   node-apiIssues and PRs related to Node-API.Issues and PRs related to Node-API.

   v12.x

   on Mar 17, 2022
3. Trott commented on Mar 18, 2022

   

   Trott

   on Mar 18, 2022

   Member

   More actions

   Node.js 12.x support ends in about 6 weeks and it is in maintenance mode where it mostly only gets security fixes. So this may not happen. However, the decision of what goes into releases and when is up to the releasers to let's ping them: @nodejs/releasers
4. XhmikosR commented on Mar 19, 2022

   

   XhmikosR

   on Mar 19, 2022

   Last edited by XhmikosR

   Contributor

   More actions

   @Trott agreed, but it seems the #37616 cherry pick should have happened in the first place :/

   We still support Node.js 12 and probably many projects do too, so it'd be nice if we could have this patch before Node.js 12 EOL :)

   🎉React with 🎉3Reacted by LongYinan, Yisi and Andrew
5. mhdawson commented on Mar 25, 2022

   

   mhdawson

   on Mar 25, 2022

   Member

   More actions

   @richardlau I see you having volunteered for likely a final release of 12.x on 2022-04-05, I assume that would be the last opportunity to get something like this in, right?

   @legendecas is going to post the list of related PR's that would also need to be cherry-picked because we believe there are a couple more that would need to go along with this.

   👍React with 👍4Reacted by Chengzhong Wu, LongYinan, Andrew and Yisi
6. richardlau commented on Mar 25, 2022

   

   richardlau

   on Mar 25, 2022

   Member

   More actions

   @richardlau I see you having volunteered for likely a final release of 12.x on 2022-04-05, I assume that would be the last opportunity to get something like this in, right?

   Correct. That is planned to be the last release of Node.js 12.x. I'm planning to put together a release proposal next week to give roughly a week to review.

   👍React with 👍1Reacted by Yisi
7. legendecas commented on Mar 27, 2022

   

   legendecas

   on Mar 27, 2022

   Last edited by legendecas

   Member

   More actions

   The related PRs of this problem are:

   Manually backported to v14.x (Backport PR: #37802):

   • node-api: force env shutdown deferring behavior node-api: force env shutdown deferring behavior #37303
   • node-api: stop ref gc during environment teardown node-api: stop ref gc during environment teardown #37616
   • node-api: fix crash in finalization node-api: fix crash in finalization #37876

   Clean land on v14.x:

   • node-api: make reference weak parameter an indirect link to references node-api: make reference weak parameter an indirect link to references #38000
   • src: fix finalization crash src: fix finalization crash #38250
   • node-api: fix shutdown crashes node-api: fix shutdown crashes #38492
   • node-api: avoid SecondPassCallback crash node-api: avoid SecondPassCallback crash #38899
   • node-api: refactor to cctest v8impl::Reference node-api: refactor to cctest v8impl::Reference #38970

   So to v12.x, we may need to backport the above PRs to fix the problem.

   👍React with 👍1Reacted by Yisi
8. richardlau commented on Apr 6, 2022

   

   richardlau

   on Apr 6, 2022

   Member

   More actions

   The backports were released in Node.js 12.22.12.

   👍React with 👍2Reacted by Andrew and Yisi

   🎉React with 🎉2Reacted by XhmikosR and Yisi
9. richardlau

   closed this as completedon Apr 6, 2022