Skip to content

Linked modules do not get added to the built-in modules #42302

Closed
#48522
Closed
Linked modules do not get added to the built-in modules#42302
#48522
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.confirmed-bugIssues and PRs for confirmed bugs.

Description

@LeonMrBonnie
LeonMrBonnie
opened on Mar 11, 2022

Version

v17.7.0

Platform

Windows

Subsystem

No response

What steps will reproduce the bug?

Compile NodeJS and add a linked module by e.g. using this command:

vcbuild.bat x64 dll link-module ./my-extra-module.js

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

The module should be available as a built-in module when using the resulting binary.

What do you see instead?

The file is missing from the file generated by the js2c script, presumably by faulty refactoring done in the past. (It still worked with NodeJS v14)

Additional information

No response

Activity

  1. ritikBhandari commented on Mar 14, 2022

    @ritikBhandari
    ritikBhandari
    on Mar 14, 2022

    Hi,
    Can I have a try on this issue?

  2. Trott
    added
    windowsIssues and PRs related to the Windows platform.
    on Mar 17, 2022
  3. richardlau
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    and removed
    windowsIssues and PRs related to the Windows platform.
    on Jun 22, 2023

  4. richardlau commented on Jun 22, 2023

    @richardlau
    richardlau
    on Jun 22, 2023
    Member

    This affects all platforms, not just Windows. It's an oversight in #39069.

    I've opened #48522 to fix.

  5. richardlau
    added
    lts-watch-v16.x
    lts-watch-v18.x
    and removed
    lts-watch-v16.x
    lts-watch-v18.x
    on Jun 22, 2023
  6. nodejs-github-bot
    closed this as completedin #48522on Jun 24, 2023
  7. nodejs-github-bot
    added a commit that references this issue on Jun 24, 2023

    build: fix `configure --link-module`

    ae9f919
  8. RafaelGSS
    added a commit that references this issue on Jul 3, 2023

    build: fix `configure --link-module`

    6551538
  9. Ceres6
    added 2 commits that reference this issue on Aug 14, 2023

    build: fix `configure --link-module`

    651f37a

    build: fix `configure --link-module`

    b5d6683
  10. targos
    added a commit that references this issue on Oct 28, 2023

    build: fix `configure --link-module`

    f2eccb7
  11. sercher
    added 2 commits that reference this issue on Apr 25, 2024

    build: fix `configure --link-module`

    bca04ed

    build: fix `configure --link-module`

    37d4ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.confirmed-bugIssues and PRs for confirmed bugs.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions