Fetch should not be installed if no_browser_globals==true

See

Lines 366 to 373 in 7904331

    
           if (!no_browser_globals()) { 
        
             result = ExecuteBootstrapper( 
        
                 this, "internal/bootstrap/browser", &node_params, &node_args); 
        
             if (result.IsEmpty()) { 
        
               return MaybeLocal<Value>(); 
        
             } 
        
           }

I could not add fetch to bootstrap/browser.js because it's not allowed to access CLI flags from this file.

src: add fetch to bootstrap/browser.js

PR: #41958

Labeling this as blocked, as there's probably no way to add fetch to the bootstrap script and honor the CLI option at the same time. We should probably just wait for fetch to become stable to be able to add it to bootstrap/browser.js. Feel free to remove the label if anyone thinks otherwise.

as there's probably no way to add fetch to the bootstrap script and honor the CLI option at the same time

I agree with that, but there's probably a way to expose no_browser_globals() to JS and add it to the condition that installs fetch.

lib: stop installing fetch if no_browser_globals is true

Ah, then #41969 should be okay, right?

lib: stop installing fetch if no_browser_globals is true

Navigation Menu

Repository navigation

Fetch should not be installed if `no_browser_globals==true` #41816

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (!no_browser_globals()) {
	result = ExecuteBootstrapper(
	this, "internal/bootstrap/browser", &node_params, &node_args);

	if (result.IsEmpty()) {
	return MaybeLocal<Value>();
	}
	}

Fetch should not be installed if no_browser_globals==true #41816

Description

Activity

RaisinTen commented on Feb 13, 2022

RaisinTen commented on Feb 14, 2022

targos commented on Feb 14, 2022

RaisinTen commented on Feb 14, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Fetch should not be installed if `no_browser_globals==true` #41816