What's the difference between .close() and .disconnect() in dgram Web Socket #41815

Activity

1. marsonya

   added

   questionIssues asking questions about Node.js.Issues asking questions about Node.js.

   dgramIssues and PRs related to UDP and the dgram module.Issues and PRs related to UDP and the dgram module.

   docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.

   on Feb 1, 2022
2. benjamingr commented on Feb 1, 2022

   

   benjamingr

   on Feb 1, 2022

   Member

   More actions

   You're being nominated as collaborator so I'll give you hints instead of a straight up answer to encourage exploration in the code:

   Disconnect:

   • You can find the code showing what they do in dgram.js
   • You will notice disconnect delegates to the handle's disconnect directly, it in turn calls uv_udp_connect(handle, nullptr) (you can check the libuv docs for what that does :))
   • Then returns and sets the state

   Close:

   • Pushes a call to close to the queue if there is one (what does the queue do? who calls enqueue in that code?)
   • Calls close on the handle (where does close come from?)
3. Trott commented on Feb 4, 2022

   

   Trott

   on Feb 4, 2022

   Member

   More actions

   .connect() and .disconnect() were added relatively recently (in 2019) by @santigimeno. You may want to look at that PR for some context in addition to the things @benjamingr points you to.
4. marsonya commented on Feb 5, 2022

   

   marsonya

   on Feb 5, 2022

   MemberAuthor

   More actions

   Apologies for the delayed reply. I had a busy week.
   Thanks for pointing me in the right direction, I will dig into the code and come up with the difference.
   I will work on it this weekend.

   👍React with 👍1Reacted by Benjamin Gruenbaum
5. marsonya commented on Feb 8, 2022

   

   marsonya

   on Feb 8, 2022

   MemberAuthor

   More actions

   Here's what I've gathered:

   Disconnect:
   It unsets the remote port and address set using connect(). That doesn't mean we stop receiving messages on the socket. Before disconnecting, we receive messages only from the remote peer set in connect(), disconnecting removes the exclusivity.
   In the code, we directly use disconnect() on the handle which calls uv_udp_connect with a NULL value in udp_wrap.cc that disconnects the handle.

   Close:
   Shuts down the socket. No more messages.
   It completely resets the handle.
   In the code, we use recvStop() on the handle which calls uv_udp_recv_stop in udp_wrap.cc that stops listening for incoming messages.

   So the difference is that close() stops new messages and shuts down the socket while disconnect() simply undoes the effects of connect() and the socket keeps listening for messages.

   👍React with 👍6Reacted by Benjamin Gruenbaum, Rich Trott, Iamgabrielsoft, Santiago Gimeno, Katrin Yordanova and newever
6. iamgabrielsoft commented on Mar 25, 2022

   

   iamgabrielsoft

   on Mar 25, 2022

   More actions

   The 'close' event is emitted after a socket is closed with close(). Once triggered, no new 'message' events will be emitted on this socket

   A synchronous function that disassociates a connected dgram.Socket from its remote address. Trying to call disconnect() on an unbound or already disconnected socket will result in an

   The writeup was gotten from https://nodejs.org/api/dgram.html#event-listening
7. santigimeno commented on Nov 7, 2022

   

   santigimeno

   on Nov 7, 2022

   Member

   More actions

   I think #41815 (comment) is the correct answer. I'm going to close this. Feel free to reopen it if you think there's still something to be solved.
8. santigimeno

   closed this as completedon Nov 7, 2022