Repository navigation
Lack of consistency in maxRequestPerSocket #40190
Description
Version
v16.10.0
Platform
all
Subsystem
http
What steps will reproduce the bug?
server.maxRequestPerSocket as defined in https://nodejs.org/api/http.html#http_server_maxrequestspersocket uses null for "no limit". However in most other places of http we use 0 to identify no limit.
server.maxRequestPerSocket should use 0 as well as null (to not break anybody), or just consider it a bugfix and remove null support.
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
No response
What do you see instead?
No response
Additional information
No response
Activity
mcollina commentedon Sep 23, 2021
cc @ronag
mcollina commentedon Sep 23, 2021
This was added in #40082
wdyt @fatal10110, would you be able to send a fix?
fatal10110 commentedon Sep 23, 2021
Sure
fatal10110 commentedon Sep 28, 2021
Since #40192 landed, I guess we can close it?
mcollina commentedon Sep 28, 2021
yes, thx