You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
+1, but would also add a word of caution. That HTTP2 standard isn't quite finalized, and till that time, it makes sense for node-spdy to be the canonical way to add SPDY support.
what exactly is this feature request for? is it for http2 support to be added to core or just for an work necessary for better support in userland to be added to core (I'm not sure what that would be).
yeah this is for core support, though developing it as a userland module until all the committers agree on the implementation would be okay with me too.
I think eventually this should land in core. Node.js was ahead of the curve with it's core http module using http 1.1 when it came out. Once http2 standard is stable, support should ideally be added to core.
I think this is a low-level, fundamental feature that deserves to be in Core.
Activity
haoxins commentedon Nov 28, 2014
+1
yosuke-furukawa commentedon Nov 28, 2014
+1
nmn commentedon Nov 28, 2014
+1, but would also add a word of caution. That HTTP2 standard isn't quite finalized, and till that time, it makes sense for node-spdy to be the canonical way to add SPDY support.
mikeal commentedon Nov 28, 2014
what exactly is this feature request for? is it for http2 support to be added to core or just for an work necessary for better support in userland to be added to core (I'm not sure what that would be).
alwayrun commentedon Nov 28, 2014
+1
nmn commentedon Nov 28, 2014
I think he's asking for http2 support in core.
Again, I think that's a great idea, but the time is not right yet.
jonathanong commentedon Nov 28, 2014
yeah this is for core support, though developing it as a userland module until all the committers agree on the implementation would be okay with me too.
mafintosh commentedon Nov 29, 2014
whats the benefit of adding this to core instead of just having it live in userland?
nmn commentedon Nov 29, 2014
I think eventually this should land in core. Node.js was ahead of the curve with it's core http module using http 1.1 when it came out. Once http2 standard is stable, support should ideally be added to core.
I think this is a low-level, fundamental feature that deserves to be in Core.
defunctzombie commentedon Nov 29, 2014
Not a core issue IMO. A distribution issue.
nmn commentedon Nov 29, 2014
Probably a little early to discuss this at all I guess. I think when the time comes, the best approach will feel obvious.
liveinjs commentedon Dec 2, 2014
+1
dconnolly commentedon Dec 3, 2014
+1
defunctzombie commentedon Dec 3, 2014
Just make a module.
ghostbar commentedon Dec 3, 2014
Can't see a win on making it part of core.
63 remaining items
test: allow tests to pass without internet
test: allow tests to pass without internet
test: allow tests to pass without internet
nodejs-github-bot commentedon Jul 27, 2025
CI: https://ci.nodejs.org/job/node-test-pull-request/68243/
nodejs-github-bot commentedon Jul 27, 2025
CI: https://ci.nodejs.org/job/node-test-pull-request/68244/
nodejs-github-bot commentedon Jul 28, 2025
CI: https://ci.nodejs.org/job/node-test-pull-request/68264/
Merge pull request nodejs#4 from tonidy/claude/analyze-recurring-bug-…
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR