Repository navigation
Intl.NumberFormat resolvedOptions style is wrong #39050
Description
- Version: v14.17.0
- Platform: Darwin *** 20.4.0 Darwin Kernel Version 20.4.0: Thu Apr 22 21:46:47 PDT 2021; root:xnu-7195.101.2~1/RELEASE_X86_64 x86_64
What steps will reproduce the bug?
(new Intl.NumberFormat('en-US', {style: 'percent'})).resolvedOptions() yields
{
locale: 'en-US',
numberingSystem: 'latn',
style: 'decimal',
minimumIntegerDigits: 1,
minimumFractionDigits: 0,
maximumFractionDigits: 0,
useGrouping: true,
notation: 'standard',
signDisplay: 'auto'
}
How often does it reproduce? Is there a required condition?
every time
What is the expected behavior?
the style entry in the resolved options should be 'percent', not 'decimal'
What do you see instead?
Additional information
It was correct in node 12, 14.16.1, and 16.3
Sorry I didn't test more of them but the 14.16 -> 14.17 breaking should be helpful
Activity
fix format number resolved options
[-]Intl.NumberFormat resolvedOptions are wrong[/-][+]Intl.NumberFormat resolvedOptions style is wrong[/+]mscdex commentedon Jun 16, 2021
Seems to be something that changed from v14.16.1, my guess is #36187.
'percent'is shown on v10.x, v12.x, v14.0.0-v14.16.1, v16.x, and master.targos commentedon Jun 16, 2021
It was my first guess too, but v14.17.1 also shows the bug and has ICU 69, like v16.x and master.
targos commentedon Jun 16, 2021
This should be fixed by #39051
Upgrade to node 14 (#2027)
test: add NumberFormat resolvedOptions test
test: add NumberFormat resolvedOptions test
deps: V8: cherry-pick b0a7f5691113
test: add NumberFormat resolvedOptions test
deps: V8: cherry-pick b0a7f5691113
test: add NumberFormat resolvedOptions test
test: add NumberFormat resolvedOptions test
test: add NumberFormat resolvedOptions test