Repository navigation
Hash.prototype._flush does not set state[kFinalized] #38727
Description
- Version: v16.1.0
- Platform: Darwin Kernel Version 20.4.0
- Subsystem: crypto
What steps will reproduce the bug?
https://github.com/nodejs/node/blob/master/lib/internal/crypto/hash.js#L90-L93
When using the stream interface of hash it will call this[kHandle].digest() in Hash.prototype._flush. After that it is possible to call Hash.prototype.digest which will call this[kHandle].digest() again. If that is ok then why is Hash.prototype.digest made in a way that it is not possible to call it more than once?
Activity
tniessen commentedon Apr 2, 2022
I believe this is to enable piping into a
Hashobject but still being able to calldigest()to obtain the hash value instead of reading from theHashobject using the stream API, whereas callingdigest()multiple times is usually unnecessary and might indicate a bug.Possibly related: #28251
I am going to close this since there has been no activity in quite a while and I don't think this is really a bug, but please do feel free to reopen or comment if you think this warrants more discussion! :)