Skip to content

Crash when using NODE_OPTIONS=--experimental-specifier-resolution=node with some .bin executables #35518

Closed as not planned
Closed as not planned
Crash when using NODE_OPTIONS=--experimental-specifier-resolution=node with some .bin executables#35518
Labels
confirmed-bugIssues and PRs for confirmed bugs.esmIssues and PRs related to the ECMAScript Modules implementation.

Description

@daveisfera
daveisfera
opened on Oct 6, 2020
  • Version: 14.13.0
  • Platform: macOS 10.15.6
  • Subsystem:

What steps will reproduce the bug?

NODE_OPTIONS=--experimental-specifier-resolution=node node_modules/.bin/semver --version

How often does it reproduce? Is there a required condition?

100%

What is the expected behavior?

Runs just like when NODE_OPTIONS isn't set

What do you see instead?

This error:

internal/process/esm_loader.js:74
    internalBinding('errors').triggerUncaughtException(
                              ^

TypeError [ERR_INVALID_RETURN_PROPERTY_VALUE]: Expected string to be returned for the "format" from the "loader getFormat" function but got type object.
    at Loader.getFormat (internal/modules/esm/loader.js:110:13)
    at async Loader.getModuleJob (internal/modules/esm/loader.js:230:20)
    at async Loader.import (internal/modules/esm/loader.js:164:17)
    at async Object.loadESM (internal/process/esm_loader.js:68:5) {
  code: 'ERR_INVALID_RETURN_PROPERTY_VALUE'
}

Additional information

Also happens with he, mocha, node-which, and tsc

Activity

  1. targos commented on Oct 11, 2020

    @targos
    targos
    on Oct 11, 2020
    Member

    I can't reproduce it on Linux.

  2. sionzee commented on Oct 11, 2020

    @sionzee
    sionzee
    on Oct 11, 2020

    I have the same issue but started happening on 14.13.1 and not 14.13.0 which was working fine.

    // Edit
    In my case it is with ts-node.

  3. sionzee commented on Oct 11, 2020

    @sionzee
    sionzee
    on Oct 11, 2020

    I think this error is happening due changes with esm-loader and is not related to NODE_OPTIONS.

    @daveisfera Can I ask to confirm if this really began happening on 14.13.0?
    Just if my theory is right :)

    If you are right then I must create another issue.

  4. daveisfera commented on Oct 14, 2020

    @daveisfera
    daveisfera
    on Oct 14, 2020
    Author

    I just tested with semver with 14.12.0 and it ran with no output, but mocha gave the same error, so I believe that it happened at least some of the time before 14.13.0

  5. targos
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    esmIssues and PRs related to the ECMAScript Modules implementation.
    on Dec 27, 2020

  6. targos commented on Dec 27, 2020

    @targos
    targos
    on Dec 27, 2020
    Member

    I can reproduce now with:

    > npm i semver
> NODE_OPTIONS=--experimental-specifier-resolution=node node_modules/.bin/semver
node:internal/process/esm_loader:74
    internalBinding('errors').triggerUncaughtException(
                              ^

TypeError [ERR_INVALID_RETURN_PROPERTY_VALUE]: Expected string to be returned for the "format" from the "loader getFormat" function but got type object.
    at new NodeError (node:internal/errors:278:15)
    at Loader.getFormat (node:internal/modules/esm/loader:111:13)
    at async Loader.getModuleJob (node:internal/modules/esm/loader:231:20)
    at async Loader.import (node:internal/modules/esm/loader:165:17)
    at async Object.loadESM (node:internal/process/esm_loader:68:5) {
  code: 'ERR_INVALID_RETURN_PROPERTY_VALUE'
}

    @nodejs/modules

  7. Norbo11 commented on Dec 27, 2020

    @Norbo11
    Norbo11
    on Dec 27, 2020

    Also seeing this when running mocha via node v14.13.1, Mac OSX 10.15.1. Running the same command under my Ubuntu VM works fine.

  8. sosoba commented on Jan 26, 2021

    @sosoba
    sosoba
    on Jan 26, 2021
    Contributor

    It's not a bug but planing feature. See https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md
    [aa26662] - module: drop support for extensionless main entry points in esm (Geoffrey Booth) #31415
    [ca81af7] - module: correct docs about when extensionless files are supported (Geoffrey Booth) #31415

  9. iambumblehead commented on Jul 28, 2023

    @iambumblehead
    iambumblehead
    on Jul 28, 2023

    the recent version node 18 lts, 18.17.0 seems have a related error, seen using the package here https://github.com/iambumblehead/esmock/tree/master/tests/tests-source-map

    the error does not happen when node 18.16.x is used, only when 18.17.x

    a link to a failed pipeline that shows the error is here https://github.com/iambumblehead/esmock/actions/runs/5688083279/job/15417439319?pr=217

    and a screenshot of the error seen from a win32 virtual machine is seen here
    Screen Shot 2023-07-27 at 8 43 19 PM

    any suggestions for resolving the issue would be very welcome

  10. GeoffreyBooth commented on Jul 28, 2023

    @GeoffreyBooth
    GeoffreyBooth
    on Jul 28, 2023
    Member

    Node 14 is EOL and this flag was removed years ago. Closing.

  11. GeoffreyBooth
    closed this as not plannedon Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.esmIssues and PRs related to the ECMAScript Modules implementation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions