Repository navigation
CodeOwner looks like not working for wasi #35162
Description
@mmarchini CodeOwner looks like not working. Is this because wasi team should have write permission for
nodejs/node repo ?
Originally posted by @gengjiawen in #35104 (comment)
Activity
gengjiawen commentedon Sep 12, 2020
cc @Trott
mmarchini commentedon Sep 12, 2020
Not related to write permissions because we now have a custom bot to circumvent that.
mmarchini commentedon Sep 12, 2020
Looking at the issue the team was mentioned for reviewing. Do you mean the team was not added as a reviewer? In that case it needs write permissions, but we settled on using the mention comment approach instead otherwise the org will become unmaintained if we have too many subteams on the collaborators team.
gengjiawen commentedon Sep 12, 2020
Yeap.
gengjiawen commentedon Sep 12, 2020
Also, related files not showing ownership. Below is a showcase for quic.
mmarchini commentedon Sep 12, 2020
Right, as I said the decision was to not use GitHub's builtin codeowners feature because of how hard it makes GitHub org management. FWIW I'm -1 to adding wasi as a subteam of collaborators, and I think we should remove the teams that are today (quic, net, http2)
Trott commentedon Sep 12, 2020
+1 to all of that. This is working as expected. We're doing the best we reasonably can within the limitations of the functionality of CODEOWNERS.
gengjiawen commentedon Sep 16, 2020
I will close it for now then.