Repository navigation
test-macOS-with-quic broken #34587
Copy link
Copy link
Closed
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.quicIssues and PRs related to the QUIC transport implementation.Issues and PRs related to the QUIC transport implementation.
Description
../src/quic/node_quic_session.cc:577:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
crypto::GetValidationErrorReason(env, err).ToLocal(&validationErrorReason);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
../src/quic/node_quic_session.cc:578:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
crypto::GetValidationErrorCode(env, err).ToLocal(&validationErrorCode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~
c++ -o /Users/runner/work/node/node/out/Release/obj.target/libnode/src/quic/node_quic_default_application.o ../src/quic/node_quic_default_application.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-DNODE_ENABLE_LARGE_CODE_PAGES=1' '-DNODE_EXPERIMENTAL_QUIC=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' '-DNGTCP2_STATICLIB' '-DNGHTTP3_STATICLIB' -I../src -I/Users/runner/work/node/node/out/Release/obj/gen -I/Users/runner/work/node/node/out/Release/obj/gen/include -I/Users/runner/work/node/node/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/uvwasi/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/ngtcp2/lib/includes -I../deps/ngtcp2/crypto/includes -I../deps/nghttp3/lib/includes -I../deps/brotli/c/include -I../deps/openssl/openssl/include -O3 -gdwarf-2 -mmacosx-version-min=10.13 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-labels -W -Wno-unused-parameter -Werror -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/runner/work/node/node/out/Release/.deps//Users/runner/work/node/node/out/Release/obj.target/libnode/src/quic/node_quic_default_application.o.d.raw -c
https://github.com/nodejs/node/actions/runs/190357710
Seems to have been introduced on a97b5f9. cc @nodejs/quic
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.quicIssues and PRs related to the QUIC transport implementation.Issues and PRs related to the QUIC transport implementation.
Activity
jasnell commentedon Jul 31, 2020
Arg... Ok, will get a PR to fix :)
jasnell commentedon Jul 31, 2020
Actually, this should be fixed already in #34541, which, if I can get another sign off, is ready to land
gengjiawen commentedon Aug 3, 2020
#34541 landed :)