Repository navigation
Stream Issues #34108
Copy link
Copy link
Closed as not planned
Labels
metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.
Description
This is a meta issue of somewhat complex issues to look into:
-
writable.end(chunk, callback)does not properly propagatewrite(chunk, callback)errors. stream: end(callback) does not propagate write after end to callback #33684 -
writable.end(chunk)API is ambiguous in relation to optional parameters (i.e. chunk). - docs say
writable.end(chunk, callback)register error handler, but will still result in unhandled exception (stream: fix writable.end callback behavior #34101) -
setEncodingshould apply transform when reading fromReadablenot when pushing into it. stream: socket.setEncoding(null) to receive binary Buffers rather than strings has no effect #6038 -
Readableconfusion/inconsistency between mutatingflowingand usingpause/resume, e.g.pipeusespausebutpipeOnDrainusesflowing=true. -
ReadablemaybeReadMoredoes not take explicit pausing into consideration and can read data despite being paused, e.g. ifpause()is called before_construct(callback)has completed, it will start reading despite being paused. stream: don't read when paused #34106 -
Readable.wrapis not streams compliant. (stream: cleanup and fix Readable.wrap #34204) -
Readable.wrapdoes not auto destroy wrapped stream. - What to do if user manually emits falsy error on stream, e.g.
emit('error', undefined)? - What if
finished(stream)is called on an errored stream? - What if
pipeline(stream)is called on an errored stream? -
finishedregisters excessive amount of listeners. - Should pipeline explicitly use
'data','drain',pause(),resume()API in order to avoid possible complexity/bugs frompipe? - Is
DuplexSocketneeded? Is it broken? -
js_socket_streamis not streams compliant.- emits
'error'instead of usingdestroy(err) - depends on flowing after pause (without resume) (http2 test fail)
- GC issues? stream: save error in state #34103 (comment)
- Crash in wrap_js_stream.js during doClose #27258
- other...
- emits
-
TLSSocketis not streams compliant.- emits
'error'instead of usingdestroy(err) - other...
- emits
- pipeline + generator issues. pipeline + generator - Premature close #33792. stream: simpler Readable async iterator #34035
- unclear
'end'semantics fornet.Socket. Probably also related tojs_socket_stream. 'end' event not called on connected socket wrapped with tls #10871
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.
Activity
github-actions commentedon Jun 27, 2026
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
github-actions commentedon Jul 28, 2026
This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.