Repository navigation
benchmark: events/eventtarget throws #33782
Description
- Version: master
- Platform: Linux
- Subsystem: events
The events/eventtarget.js benchmark fails every time with:
internal/event_target.js:250
throw new ERR_EVENT_RECURSION(event.type);
^
Error [ERR_EVENT_RECURSION]: The event "foo" is already being dispatched
at EventTarget.dispatchEvent (internal/event_target.js:250:13)
at main (/home/bench/node/benchmark/events/eventtarget.js:20:12)
at /home/bench/node/benchmark/common.js:42:9
at processTicksAndRejections (internal/process/task_queues.js:79:11) {
code: 'ERR_EVENT_RECURSION'
}
/cc @jasnell
Activity
benjamingr commentedon Jun 8, 2020
I think this is already fixed by #33624 which just needs to land (along with the other PRs)
mscdex commentedon Jun 19, 2020
Can we temporarily remove this benchmark in the meantime? I checked and the linked PR is evidently not enough to fix the error with the benchmark. In particular this issue is currently preventing the gathering of all
eventsbenchmark data (EventTargetor otherwise) in my daily benchmark runner.benchmark: fix EventTarget benchmark
benchmark: fix EventTarget benchmark
benchmark: fix EventTarget benchmark
benchmark: fix EventTarget benchmark