Unexpected performance penalty when using field initialiser #33698

Activity

1. devsnek commented on Jun 2, 2020

   

   devsnek

   on Jun 2, 2020

   Member

   More actions

   Can you post a reproduction that uses only pure JavaScript?

   👍React with 👍1Reacted by Pawel Badenski
2. devsnek

   added

   v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.

   on Jun 2, 2020
3. devsnek commented on Jun 2, 2020

   

   devsnek

   on Jun 2, 2020

   Member

   More actions

   @pbadenski thanks, i would recommend reporting this to https://bugs.chromium.org/p/v8/issues/list
4. lpinca commented on Jun 2, 2020

   

   lpinca

   on Jun 2, 2020

   Last edited by lpinca

   Member

   More actions

   A_field_initialized_in_constructor x 812,776,791 ops/sec ±0.94% (91 runs sampled)

   I'm pretty sure this is optimized into a noop. Try to do something like this

   let instance;
   
   suite.add('A_field_initialized_in_constructor', function() {
     instance = new A_field_initialized_in_constructor();
     return instance;
   });
   
   suite.add('B_field_initialized_as_class_property', function() {
     instance = new B_field_initialized_as_class_property();
     return instance;
   });

   and see if it changes the results.

   👍React with 👍2Reacted by Denys Otrishko and Erik
5. pbadenski commented on Jun 3, 2020

   

   pbadenski

   on Jun 3, 2020

   Last edited by pbadenski

   Author

   More actions

   @lpinca I followed the suggestion - the difference reduced to one order of magnitude, but still surprisingly large:

   A_field_initialized_in_constructor x 77,519,027 ops/sec ±1.85% (90 runs sampled)
   B_field_initialized_as_class_property x 6,270,322 ops/sec ±1.21% (88 runs sampled)
   

   Test:

   const { Options, Suite } = require("benchmark");
   
   const runBenchmarkSuite = (suite) => {
     return new Promise((resolve, reject) => {
       suite
         .on("start", (e) => console.log(`Running test: ${e.currentTarget.name}`))
         .on("cycle", (e) => console.log(String(e.target)))
         .on("complete", (e) => console.log(`Fastest is ${e.currentTarget.filter("fastest").map("name")}`))
         .on("complete", resolve)
         .on("error", reject)
         .run();
     });
   };
   
   class A_field_initialized_in_constructor {
     constructor() {
       this.foo = true;
     }
   
   }
   
   class B_field_initialized_as_class_property {
     foo = true;
   }
   
   let instance;
   runBenchmarkSuite(new Suite("fields")
     .add("A_field_initialized_in_constructor", () => {
       instance = new A_field_initialized_in_constructor();
       return instance;
     })
     .add("B_field_initialized_as_class_property", () => {
       instance = new B_field_initialized_as_class_property();
       return instance;
     })
   );

   I'll report to v8.

   👍React with 👍1Reacted by T. Nishino
6. targos commented on Nov 20, 2021

   

   targos

   on Nov 20, 2021

   Member

   More actions

   Closing as this should be fixed in V8. Feel free to post a link to the V8 issue if it exists.
7. targos

   closed this as completedon Nov 20, 2021