util.inspect shouldn’t format objects with the [[IsHTMLDDA]] internal slot as undefined #31889

Activity

1. devsnek commented on Feb 20, 2020

   

   devsnek

   on Feb 20, 2020

   Last edited by devsnek

   Member

   More actions

   I suppose this would matter when using electron, since you could actually do util.inspect(document.all). I can add an upstream Object::IsUndetectable and we could check it here.

   We could also hack this in as typeof v === 'undefined' && v !== undefined.

   👍React with 👍2Reacted by ExE Boss and Anna Henningsen
2. devsnek

   added

   utilIssues and PRs related to the built-in util module.Issues and PRs related to the built-in util module.

   v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.

   on Feb 20, 2020
3. ExE-Boss commented on Feb 21, 2020

   

   ExE-Boss

   on Feb 21, 2020

   Last edited by ExE-Boss

   ContributorAuthor

   More actions

   One solution would be to add util.types.isObject(target), which would perform:

   1. If Type(target) is Object, then return true.
   2. Return false.

   That would take care of that check, as C++ code doesn’t care whether an object is undetectable, since you can pass document.all as the this value to both Function.prototype.toString, Object.prototype.toString and Object.prototype.valueOf.

   ---

   A polyfilled version is:

   function isObject(target) {
   	if (target === null || target === undefied) return false;
   	switch (typeof target) {
   		case "object":
   		case "function":
   			return true;
   		case "undefined":
   			try {
   				return Object.prototype.valueOf.call(target) === target;
   			} catch {}
   	}
   	return false;
   }
4. devsnek

   added a commit that references this issue on Mar 10, 2020

   util: fix inspecting document.all

   ...

   f66fda7
5. addaleax

   closed this as completedin 89ae1f1on Mar 30, 2020
6. addaleax

   added a commit that references this issue on Mar 30, 2020

   util: fix inspecting document.all

   ...

   6d86651
7. targos

   added a commit that references this issue on Apr 22, 2020

   util: fix inspecting document.all

   ...

   eccd2a7
8. sjarmak

   added a commit that references this issue on Jul 27, 2026

   util: fix inspecting document.all

   ...

   89ae1f1