src: make buffers 2**32 index proof

Refs: #31399

Audit src/node_buffer.cc, lib/buffer.js and lib/internal/buffer.js - there are places where assumptions are made about the type of indices, e.g.:

node/src/node_buffer.cc

Lines 593 to 596 in 3ff2aec

    
           uint32_t start; 
        
           if (!args[2]->Uint32Value(ctx).To(&start)) return; 
        
           uint32_t end; 
        
           if (!args[3]->Uint32Value(ctx).To(&end)) return;

I suspect most C++ code can be switched over to ParseArrayIndex().

src: change Fill() to use ParseArrayIndex()

Navigation Menu

Repository navigation

src: make buffers 2**32 index proof #31514

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	uint32_t start;
	if (!args[2]->Uint32Value(ctx).To(&start)) return;
	uint32_t end;
	if (!args[3]->Uint32Value(ctx).To(&end)) return;

src: make buffers 2**32 index proof #31514

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions