Skip to content

--experimental modules flags should have warnings #30600

Closed
Closed
--experimental modules flags should have warnings#30600
Labels
esmIssues and PRs related to the ECMAScript Modules implementation.good first issueIssues that are suitable for first-time contributors.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.

Description

@guybedford
guybedford
opened on Nov 22, 2019

Currently the following experimental modules flags don't have warnings:

  • --experimental-json-modules
  • --experimental-wasm-modules
  • --experimental-resolve-self
  • --experimental-conditional-exports
  • --es-module-specifier-resolution=node

Ideally when using any of these flags we should provide a warning message that not only is the base experimental modules implementation unstable, but these flags are not even clear if they will be provided as final features in the implementation and any of them might be removed still.

Activity

  1. guybedford
    added
    esmIssues and PRs related to the ECMAScript Modules implementation.
    on Nov 22, 2019

  2. pd4d10 commented on Nov 23, 2019

    @pd4d10
    pd4d10
    on Nov 23, 2019
    Contributor

    If multiple experimental flags specified, should these warnings emitted separately for every flag, or merged into one?

  3. guybedford commented on Nov 23, 2019

    @guybedford
    guybedford
    on Nov 23, 2019
    ContributorAuthor

    I would prefer one for each. Warning consolidation is a separate consideration for Node.js more generally I think.

  4. guybedford commented on Nov 23, 2019

    @guybedford
    guybedford
    on Nov 23, 2019
    ContributorAuthor

    For at least --experimental-json-modules, --experimental-wasm-modules it should be possible to move the warnings to their first use.

    For --experimental-resolve-self and --experimental-conditional-exports the first use would be within C++ code and applies both to the CJS and ESM resolver implementations so may be a bit trickier, but it is in theory possible.

  5. guybedford
    added
    good first issueIssues that are suitable for first-time contributors.
    help wantedIssues that need assistance from volunteers or PRs that need help to proceed.
    on Nov 25, 2019
  6. guybedford
    closed this as completedin aa4c57aon Dec 5, 2019
  7. targos
    added a commit that references this issue on Dec 9, 2019

    module: add warnings for experimental flags

    851f313
  8. MylesBorins
    added a commit that references this issue on Jan 12, 2020

    module: add warnings for experimental flags

    f0850a3
  9. BethGriggs
    added a commit that references this issue on Feb 6, 2020

    module: add warnings for experimental flags

    dc084f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    esmIssues and PRs related to the ECMAScript Modules implementation.good first issueIssues that are suitable for first-time contributors.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions