Repository navigation
fs.existSync returns true after fs. symlinkSync node 10 onwards in windows only #30538
Description
Hi,
I started seeing a difference in behavior when I run the following code in Linux and Windows in node 10 and node 12.
const fs = require('fs');
console.log(`Before symlink: ${fs.existsSync('linkHere')}`);
fs.symlinkSync('test/foo.js', 'linkHere');
console.log(`After symlink: ${fs.existsSync('linkHere')}`);
console.log(`issymlink: ${fs.lstatSync('linkHere').isSymbolicLink()}`);
//cleanup
fs.unlinkSync('linkHere');I created reproduction repo and travis, appveyor CI to show the difference.
Please check the output of the above snippet;
- node 8
- linux
$ node --version
v8.16.2
> node index.js
Before symlink: false
After symlink: false
issymlink: true- windows
$ node index.js
Before symlink: false
After symlink: false
issymlink: true- node 10
- linux
$ node --version
v10.17.0
> node index.js
Before symlink: false
After symlink: false
issymlink: true- windows
Installing node 10.17.0 (x86)...
$ node index.js
Before symlink: false
After symlink: true
issymlink: trueI am not sure why are we getting different result for same code in windows and Linux? Is it a bug or am I missing something.
Reproduction repo: https://github.com/SparshithNR/node-symlink
Travis build: https://travis-ci.com/SparshithNR/node-symlink/builds/137133722
appveyor build: https://ci.appveyor.com/project/SparshithNR/node-symlink
Thank you in advance :)
Activity
pd4d10 commentedon Nov 19, 2019
It seems reasonable at Linux, because the link is broken (There is no
test/foo.jsfile)If
test/foo.jsexists the second result would betrue.pd4d10 commentedon Nov 19, 2019
The behavior of Windows seems caused by using
accessinstead ofstatto implementexistsSync, See #18618Maybe we should firstly add some tests to
test-fs-exists.jsto cover this caseSparshithNR commentedon Nov 19, 2019
@pd4d10 Thanks for the response. Should I consider this issue as a bug in the windows?
Fishrock123 commentedon Nov 19, 2019
Perhaps
existsshould just check bothaccessandstaton Windows...fs: fix existsSync for invalid symlink at win32
fs: fix existsSync for invalid symlink at win32
fs: fix existsSync for invalid symlink at win32