Skip to content

investigate flaky test-inspector-contexts in CI #30519

Closed
Closed
investigate flaky test-inspector-contexts in CI#30519
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.

Description

@gireeshpunathil
gireeshpunathil
opened on Nov 18, 2019
  • Version:
  • Platform:
  • Subsystem:

sequential/test-inspector-contexts is flaking (timing out) a lot in the CI. Discovered while I was running CI for progressing the C&L PRs.

Example failure:

13:05:40 not ok 1307 sequential/test-inspector-contexts
13:05:40   ---
13:05:40   duration_ms: 148.541
13:05:40   severity: fail
13:05:40   exitcode: 1
13:05:40   stack: |-
13:05:40     timeout
13:05:40     Testing context created/destroyed notifications
13:05:40   ...

https://ci.nodejs.org/job/node-test-binary-windows-2/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/4208/console

cc @nodejs/testing @nodejs/v8-inspector

Activity

  1. Trott commented on Nov 26, 2019

    @Trott
    Trott
    on Nov 26, 2019
    Member

    Happened again today.

    https://ci.nodejs.org/job/node-test-binary-windows-2/4494/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console

    21:44:04 not ok 1311 sequential/test-inspector-contexts
21:44:04   ---
21:44:04   duration_ms: 150.925
21:44:04   severity: fail
21:44:04   exitcode: 1
21:44:04   stack: |-
21:44:04     timeout
21:44:04     Testing context created/destroyed notifications
21:44:04   ...

    test-azure_msft-win2016-x64-3

  2. Trott commented on Nov 26, 2019

    @Trott
    Trott
    on Nov 26, 2019
    Member

    I wonder if session.post() is failing but since no callback is sent, the error is never received?

  3. Trott commented on Nov 26, 2019

    @Trott
    Trott
    on Nov 26, 2019
    Member

    I notice that if I modify mainContextPromise such that it never executes, the test still passes. Will add a common.mustCall() to make sure the test suites actually run.

  4. Trott commented on Nov 26, 2019

    @Trott
    Trott
    on Nov 26, 2019
    Member

    Confirmed that if session.post() errors, it is ignored with no callback. Will add that to the PR.

  5. Trott commented on Nov 27, 2019

    @Trott
    Trott
    on Nov 27, 2019
    Member

    #30649 (comment)

    Welp, this at least has the desired effect of supplying more information about why test-inspector-contexts sometimes hangs in CI.

    13:29:09 not ok 1312 sequential/test-inspector-contexts
13:29:09   ---
13:29:09   duration_ms: 149.140
13:29:09   severity: fail
13:29:09   exitcode: 1
13:29:09   stack: |-
13:29:09     timeout
13:29:09     Testing context created/destroyed notifications
13:29:09     Checking/waiting for GC.
13:29:09   ...

    So it looks like it just runs the first global.gc() over and over and the context is never garbage collected/destroyed?

  6. Trott commented on Nov 27, 2019

    @Trott
    Trott
    on Nov 27, 2019
    Member

    @nodejs/inspector @nodejs/vm @nodejs/testing Any thoughts on what to do next to troubleshoot?

  7. Trott
    added a commit that references this issue on Nov 28, 2019

    test: add mustCall() to test-inspector-contexts

    80c170e
  8. addaleax
    added a commit that references this issue on Nov 30, 2019

    test: add mustCall() to test-inspector-contexts

    3769632
  9. targos
    added a commit that references this issue on Dec 1, 2019

    test: add mustCall() to test-inspector-contexts

    23ad927
  10. MylesBorins
    added a commit that references this issue on Dec 17, 2019

    test: add mustCall() to test-inspector-contexts

    c3ad977
  11. targos
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Dec 26, 2020

  12. targos commented on Dec 26, 2020

    @targos
    targos
    on Dec 26, 2020
    Member

    Is this still relevant?

  13. Trott commented on Jan 6, 2021

    @Trott
    Trott
    on Jan 6, 2021
    Member

    Is this still relevant?

    I'm not seeing it using ncu-ci walk pr or ncu-ci walk commit so I'm going to optimistically close this.

  14. Trott
    closed this as completedon Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions