Repository navigation
Shouldn't DNS error code 'EADNAME' be 'EBADNAME'? #3050
Description
See https://github.com/nodejs/node/blob/master/lib/dns.js#L333
exports.ADNAME = 'EADNAME';This line defines the error code ADNAME as 'EADNAME'. Shouldn't it be BADNAME and 'EBADNAME' respectively?
exports.BADNAME = 'EBADNAME';
Activity
ChALkeR commentedon Sep 24, 2015
The doc mentions
BADNAME: https://nodejs.org/api/dns.html#dns_error_codessilverwind commentedon Sep 24, 2015
Looks like an mistake in ecfe32e. This change would be a semver-major.
silverwind commentedon Sep 24, 2015
(Unless that error code isn't returned by the API)
ChALkeR commentedon Sep 24, 2015
@silverwind Adding
exports.BADNAMEwould be asemver-minor, removingexports.ADNAMEwould be asemver-majorin any case (even if not returned by the API). So I would prefer that to be two separate commits, one of which could be pulled in 4.x.silverwind commentedon Sep 24, 2015
What are these exports actually used for exactly? They don't seem to be involved in actual error handling. They certainly are undocumented, so semver rules don't strictly apply.
silverwind commentedon Sep 24, 2015
cc: @piscisaureus who added them in 858f230
ChALkeR commentedon Sep 24, 2015
https://nodejs.org/api/dns.html#dns_error_codes
silverwind commentedon Sep 24, 2015
Oh, right, comparison. Well, I think a replacement here would qualify as a bugfix to match the documentation, so I think it'd be fine in a patch release actually.
silverwind commentedon Sep 24, 2015
Filed #3051.
trevnorris commentedon Sep 25, 2015
Agreed that if the documented result doesn't match how the code works then it's a bug fix.
dns: remove nonexistant exports.ADNAME
dns: remove nonexistant exports.ADNAME
silverwind commentedon Sep 27, 2015
Landed in two seperate commits.
exports.BADNAMEwill be available next version.exports.ADNAMEwill be removed in 5.0.0.dns: add missing exports.BADNAME
dns: remove nonexistant exports.ADNAME
dns: remove nonexistant exports.ADNAME
dns: remove nonexistant exports.ADNAME
dns: add missing exports.BADNAME