Skip to content

doc: add NO_COLOR to disable colors in assert doc #30484

Closed
Closed
doc: add NO_COLOR to disable colors in assert doc#30484
Labels
assertIssues and PRs related to the assert subsystem.docIssues and PRs related to Node.js documentation.

Description

@shobhitchittora
shobhitchittora
opened on Nov 14, 2019

Currently the assert docs point to only NODE_DISABLE_COLORS env variable to disable tty colors. NO_COLOR does the same thing.

Going ahead and creating a small PR to add the variable there.

  • Version: v12.8.0
  • Platform: Darwin Kernel Version 18.7.0
  • Subsystem: doc

Activity

  1. lpinca
    added
    assertIssues and PRs related to the assert subsystem.
    docIssues and PRs related to Node.js documentation.
    on Nov 17, 2019
  2. addaleax
    added a commit that references this issue on Nov 18, 2019

    doc: adds NO_COLOR to assert doc page

    5bb4d85
  3. BridgeAR
    added a commit that references this issue on Nov 19, 2019

    doc: adds NO_COLOR to assert doc page

    7f664e4
  4. targos
    added a commit that references this issue on Dec 1, 2019

    doc: adds NO_COLOR to assert doc page

    8bb232f

  5. lpinca commented on Dec 7, 2019

    @lpinca
    lpinca
    on Dec 7, 2019
    Member

    Fixed by #30483.

  6. lpinca
    closed this as completedon Dec 7, 2019
  7. MylesBorins
    added a commit that references this issue on Dec 17, 2019

    doc: adds NO_COLOR to assert doc page

    ec5fe99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    assertIssues and PRs related to the assert subsystem.docIssues and PRs related to Node.js documentation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions