You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the provided test guidelines, it is preferred to use arrow functions for call backs. test/addons/make-callback-recurse/test.js contains many regular functions with common.mustCall(), so it needs to be refactored.
Activity
mpark86 commentedon Oct 22, 2019
I would like to start working on this.
Fix nodejs#30068: refactored to use arrow functions
Trott commentedon Oct 22, 2019
There are 83 files in subdirectories of the
testdirectory namedtest.js.Trott commentedon Oct 22, 2019
Ah, I see from the PR you are referring to test/addons/make-callback-recurse/test.js.
mpark86 commentedon Oct 24, 2019
Thanks for pointing that out. I just fixed the issue description to include the full path as well.
Trott commentedon Oct 25, 2019
Closed by 175c318