Skip to content

n-api: add napi_is_detached_arraybuffer() #29955

Closed
Closed
n-api: add napi_is_detached_arraybuffer()#29955
Labels
node-apiIssues and PRs related to Node-API.

Description

@gabrielschulhof
gabrielschulhof
opened on Oct 13, 2019

We should add napi_is_detached_arraybuffer() as in https://www.ecma-international.org/ecma-262/9.0/#sec-isdetachedbuffer

cc: @legendecas

Activity

  1. legendecas commented on Oct 13, 2019

    @legendecas
    legendecas
    on Oct 13, 2019
    Member

    I'd wonder if a napi_is_detachable_arraybuffer would be more suitable and able to cover more situations. As internal buffers in V8 would not be detachable ( Also in JerryScript, which implements internal arraybuffer with inlined back store), an arraybuffer that has not been detached before would still be not detachable.

  2. legendecas commented on Oct 13, 2019

    @legendecas
    legendecas
    on Oct 13, 2019
    Member

    One might be concerning that is_detachable is not defined in ECMA spec.

  3. Fishrock123
    added
    node-apiIssues and PRs related to Node-API.
    on Oct 14, 2019

  4. mhdawson commented on Oct 17, 2019

    @mhdawson
    mhdawson
    on Oct 17, 2019
    Member

    @legendecas agreed, we would like to stick to what is in the ECMA spec in most cases.

  5. addaleax
    closed this as completedin a1cbbd1on Nov 28, 2019
  6. addaleax
    added a commit that references this issue on Nov 30, 2019

    n-api: implement napi_is_detached_arraybuffer

    8171cef
  7. lundibundi
    added a commit that references this issue on Jan 20, 2020

    n-api: implement napi_is_detached_arraybuffer

    68afe9e
  8. MylesBorins
    added a commit that references this issue on Jan 30, 2020

    n-api: implement napi_is_detached_arraybuffer

    ea3d4e8
  9. BethGriggs
    added a commit that references this issue on Feb 6, 2020

    n-api: implement napi_is_detached_arraybuffer

    b5d42ae
  10. legendecas
    added a commit that references this issue on Jul 1, 2020

    n-api: implement napi_is_detached_arraybuffer

    8ec28f5
  11. richardlau
    added a commit that references this issue on Jul 1, 2020

    n-api: implement napi_is_detached_arraybuffer

    b744ffd
  12. sjarmak
    added a commit that references this issue on Jul 27, 2026

    n-api: implement napi_is_detached_arraybuffer

    a1cbbd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    node-apiIssues and PRs related to Node-API.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions