Repository navigation
tools: check-imports.py false negatives #29226
Description
Refs: #29222
As that PR shows, there are some unused imports that tools/check-imports.py doesn't catch because:
- They're used in comments.
- The tool doesn't match at word boundaries (e.g.
FromJustis considered a use ofJust.)
Activity
ayushmandey97 commentedon Sep 16, 2019
Hey, I'm a bit new to opensource. Have some experience with Python and regex, and this looks interesting. Can I take this up?
sam-github commentedon Sep 16, 2019
@ayushmandey97 Yes, you are welcome to, thanks.
tools: fixed check-imports.py to ignore commented lines
ayushmandey97 commentedon Sep 30, 2019
I'll be adding support for multi-line comments as well.
There's one issue though, I added a dummy 'using' statement in one of the .cc files to check if an error was thrown, but the check-imports.py file ran without any log statements.
Any suggestions on how to test it in-case that's a wrong approach?
Another thing, since this is my first PR for Node, please feel free to let me know if I've made mistakes in the process or the code itself.
tools: Commented lines with spaces/tabs will also be ignored now
tools: fixed check-imports.py to ignore commented lines
tools: Commented lines with spaces/tabs will also be ignored now
ayushmandey97 commentedon Nov 24, 2019
@sam-github the checks have been implemented. Please review once and let me know if any changes are required.
@bnoordhuis please have a look at the PR.
src: remove unused using declarations
tools: fix check-imports.py to match on word boundaries
ayushmandey97 commentedon May 29, 2020
@sam-github looks like another PR for this issue got merged while I didn't get any feedback on the one I raised, was there a reason for this? Let me know if I missed something
src: remove unused using declarations
tools: fix check-imports.py to match on word boundaries
src: remove unused using declarations
tools: fix check-imports.py to match on word boundaries
tools: fix check-imports.py to match on word boundaries
src: remove unused using declarations