fs: streams emitClose #29177

Activity

1. gntem commented on Aug 19, 2019

   

   gntem

   on Aug 19, 2019

   Contributor

   More actions

   hello tried to make this I see there are some backwards compatibility concerns

   how does this look ?

   diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js
   index dfff08dbbd..d8776598f7 100644
   --- a/lib/internal/fs/streams.js
   +++ b/lib/internal/fs/streams.js
   @@ -65,7 +65,9 @@ function ReadStream(path, options) {
        options.highWaterMark = 64 * 1024;
    
      // For backwards compat do not emit close on destroy.
   -  options.emitClose = false;
   +  if (typeof options.emitClose !== 'boolean') {
   +    options.emitClose = false;
   +  }
    
      Readable.call(this, options);
    
   @@ -241,7 +243,9 @@ function WriteStream(path, options) {
      options = copyObject(getOptions(options, {}));
    
      // For backwards compat do not emit close on destroy.
   -  options.emitClose = false;
   +  if (typeof options.emitClose !== 'boolean') {
   +    options.emitClose = false;
   +  }
    
      Writable.call(this, options);
    

   👍React with 👍1Reacted by Robert Nagy
2. ronag commented on Aug 19, 2019

   

   ronag

   on Aug 19, 2019

   MemberAuthor

   More actions

   instead of checking for typeof boolean I would check for undefined
3. gntem

   added a commit that references this issue on Aug 19, 2019

   fs: allow passing true to emitClose option

   ...

   df1ba97
4. Fishrock123

   added

   streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.

   fsIssues and PRs related to file-system APIs and the fs module.Issues and PRs related to file-system APIs and the fs module.

   on Aug 19, 2019
5. Trott

   closed this as completedin eeea3fbon Aug 23, 2019
6. Trott

   added 2 commits that reference this issue on Aug 23, 2019

   test: add `emitClose: true` tests for fs streams

   ...

   cb92126

   doc: add emitClose option for fs streams

   ...

   47ff44e
7. BridgeAR

   added 3 commits that reference this issue on Sep 3, 2019

   fs: allow passing true to emitClose option

   ...

   8f47ff1

   test: add `emitClose: true` tests for fs streams

   ...

   1f88ca3

   doc: add emitClose option for fs streams

   ...

   65de900
8. sjarmak

   added a commit that references this issue on Jul 27, 2026

   fs: allow passing true to emitClose option

   ...

   eeea3fb