Repository navigation
stream: event contract #29005
Description
Try to follow the assumed "contract"/"api" in terms of stream events:
events (only close after error, nothing after close, only error or close after destroy)
- don't emit finish on error (stream: don't emit finish on error #28979)
- document when destroy emits events (doc: clarify when destroy emits events #28970)
- don't emit open after destroy ([x] fs: don't emit open after destroy #28765)
- don't emit after 'error' (stream: don't emit after 'error' #28708)
- don't emit finish on error (stream: don't emit finish on error #28979)
- eos premature close (stream: eos premature close #28720)
Activity
Fishrock123 commentedon Aug 7, 2019
Are these supposed to be check off?
ronag commentedon Aug 8, 2019
I checked them when there was a PR. But maybe it makes more sense to check them when it's been merged.
ronag commentedon Oct 6, 2019
I'm moving this into my own list and will open PR's accordingly when my number of open PR's drop.