Intermittent timeouts in test-tls-min-max-version.js  #28337

Activity

1. addaleax

   added

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   tlsIssues and PRs related to the tls subsystem.Issues and PRs related to the tls subsystem.

   on Jun 21, 2019
2. sam-github commented on Jun 21, 2019

   

   sam-github

   on Jun 21, 2019

   Contributor

   More actions

   Can you post the output? Also, just to confirm, what were your configure options?
3. sam-github

   added

   macosIssues and PRs related to the macOS platform.Issues and PRs related to the macOS platform.

   on Jun 21, 2019
4. kball commented on Jun 21, 2019

   

   kball

   on Jun 21, 2019

   ContributorAuthor

   More actions

   I ran ./configure with no options; where should I look to find any info on what it determined that will be helpful?

   I unfortunately did not save the output and am not currently able to reproduce. :( I'll keep trying and post it if I repro it again. Sorry for not thinking of that.
5. sam-github commented on Jun 22, 2019

   

   sam-github

   on Jun 22, 2019

   Contributor

   More actions

   Knowing that there were no options is enough.

   Without some output, its hard to guess, much less repro. This runs regularly in CI on macos, and many (most?) devs are using macos, so its surprising. It also is a pretty simple test with no subtle timing races or ordering dependencies. Which doesn't mean it doesn't have a bug, but does mean that some clues are needed.

   I don't even know what timeout you hit, if you run it standalone, I didn't think there were any timeouts.
6. lpinca commented on Jul 28, 2019

   

   lpinca

   on Jul 28, 2019

   Last edited by lpinca

   Member

   More actions

   I can reproduce with

   ./tools/test.py -J --repeat=1000 test/parallel/test-tls-min-max-version.js
   

   on master. macOS 10.14.5
7. lpinca

   added

   flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

   on Jul 28, 2019
8. lpinca commented on Jul 28, 2019

   

   lpinca

   on Jul 28, 2019

   Member

   More actions

   I dug a little and noticed a bunch of EADDRNOTAVAIL errors. When this happens

   node/test/fixtures/tls-connect.js

   Line 70 in 35cb955

   .on('error', function(err) {

   is emitted but

   node/test/fixtures/tls-connect.js

   Line 81 in 35cb955

   }).on('tlsClientError', function(err, sock) {

   is not. As a result the callback is not called and test times out. I've increased the ephemeral port range

   $ sudo sysctl -w net.inet.ip.portrange.first=32768
   net.inet.ip.portrange.first: 49152 -> 32768
   

   and reduced the duration of the TIME_WAIT state

   $ sudo sysctl net.inet.tcp.msl=1000
   net.inet.tcp.msl: 15000 -> 1000
   

   and now it works with no timeouts. I'm not sure if there is anything actionable to do.
9. targos commented on Nov 20, 2021

   

   targos

   on Nov 20, 2021

   Member

   More actions

   Closing as there was no recent activity
10. targos

    closed this as completedon Nov 20, 2021