Skip to content

Investigate flaky parallel/test-https-connect-localport #26862

Closed
Closed
Investigate flaky parallel/test-https-connect-localport#26862
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.

Description

@joyeecheung
joyeecheung
opened on Mar 22, 2019

Refs: nodejs/reliability#21

Reason parallel/test-https-connect-localport
Type JS_TEST_FAILURE
Failed PR 4 (#26810, #26738, #26760, #26802)
Appeared test-osuosl-ubuntu1404-ppc64_le-1, test-osuosl-ubuntu1404-ppc64_le-2, test-packetnet-centos7-arm64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/21713/
Last CI https://ci.nodejs.org/job/node-test-pull-request/21769/
Example 
not ok 1129 parallel/test-https-connect-localport
  ---
  duration_ms: 0.171
  severity: fail
  exitcode: 1
  stack: |-
    (node:7223) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
    events.js:170
          throw er; // Unhandled 'error' event
          ^
    
    Error: bind EADDRINUSE 0.0.0.0:34567
        at internalConnect (net.js:806:18)
        at defaultTriggerAsyncIdScope (internal/async_hooks.js:297:19)
        at net.js:930:9
        at processTicksAndRejections (internal/process/task_queues.js:79:9)
        at process.runNextTicks [as _tickCallback] (internal/process/task_queues.js:56:3)
        at Function.Module.runMain (internal/modules/cjs/loader.js:880:11)
        at internal/main/run_main_module.js:21:11
    Emitted 'error' event at:
        at TLSSocket.socketErrorListener (_http_client.js:401:9)
        at TLSSocket.emit (events.js:193:13)
        at emitErrorNT (internal/streams/destroy.j...

Activity

  1. joyeecheung commented on Mar 22, 2019

    @joyeecheung
    joyeecheung
    on Mar 22, 2019
    MemberAuthor

    Judging from the first CI this appeared, this might be related to #26209

    cc @sam-github ?

  2. joyeecheung
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Mar 22, 2019

  3. Trott commented on Mar 23, 2019

    @Trott
    Trott
    on Mar 23, 2019
    Member

    https://ci.nodejs.org/job/node-test-commit-plinux/24626/nodes=ppcle-ubuntu1404/console

    test-osuosl-ubuntu1404-ppc64_le-1

    00:04:14 not ok 1129 parallel/test-https-connect-localport
00:04:14   ---
00:04:14   duration_ms: 0.185
00:04:14   severity: fail
00:04:14   exitcode: 1
00:04:14   stack: |-
00:04:14     (node:21338) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
00:04:14     events.js:171
00:04:14           throw er; // Unhandled 'error' event
00:04:14           ^
00:04:14     
00:04:14     Error: bind EADDRINUSE 0.0.0.0:34567
00:04:14         at internalConnect (net.js:806:18)
00:04:14         at defaultTriggerAsyncIdScope (internal/async_hooks.js:298:19)
00:04:14         at net.js:930:9
00:04:14         at processTicksAndRejections (internal/process/task_queues.js:79:9)
00:04:14         at process.runNextTicks [as _tickCallback] (internal/process/task_queues.js:56:3)
00:04:14         at Function.Module.runMain (internal/modules/cjs/loader.js:880:11)
00:04:14         at internal/main/run_main_module.js:21:11
00:04:14     Emitted 'error' event at:
00:04:14         at TLSSocket.socketErrorListener (_http_client.js:401:9)
00:04:14         at TLSSocket.emit (events.js:194:13)
00:04:14         at emitErrorNT (internal/streams/destroy.js:91:8)
00:04:14         at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
00:04:14         at processTicksAndRejections (internal/process/task_queues.js:81:17)
00:04:14         at process.runNextTicks [as _tickCallback] (internal/process/task_queues.js:56:3)
00:04:14         at Function.Module.runMain (internal/modules/cjs/loader.js:880:11)
00:04:14         at internal/main/run_main_module.js:21:11
00:04:14   ...

  4. Trott commented on Mar 23, 2019

    @Trott
    Trott
    on Mar 23, 2019
    Member

    The problem is that the test has a hard-coded port which no test in parallel should have since it will sometimes conflict with other tests in parallel that ask the OS for an unspecified available port. I'll open a PR to fix....

  5. Trott
    added a commit that references this issue on Mar 23, 2019

    test: move test-https-connect-localport to sequential

    dad3deb

  6. Trott commented on Mar 23, 2019

    @Trott
    Trott
    on Mar 23, 2019
    Member

    PR to fix: #26881

  7. Trott
    added 4 commits that reference this issue on Mar 24, 2019

    test: move test-https-connect-localport to sequential

    0f7e24a

    test: use common.PORT instead of hardcoded number

    229759f

    test: replace localhost IP with 'localhost' for TLS conformity

    f5969f0

    test: refactor test-https-connect-localport

    4a40ea6
  8. Trott
    closed this as completedin 0f7e24aon Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions