Debug build fails on Windows: Assertion failed: vector iterators incompatible #26694

Activity

1. addaleax commented on Mar 15, 2019

   

   addaleax

   on Mar 15, 2019

   Member

   More actions

   Are you talking about a released version of Node.js or the master branch? The fix should be included in #26685.
2. billti commented on Mar 15, 2019

   

   billti

   on Mar 15, 2019

   ContributorAuthor

   More actions

   I just did a sync/build of master this morning and hit this issue, so a new drop should fix in master. (A git tag --contains 385aa80aff32210 shows that fix is in the V8 7.4.288.8 being targeted.

   Thanks!
3. billti

   closed this as completedon Mar 15, 2019
4. refack commented on Mar 16, 2019

   

   refack

   on Mar 16, 2019

   Last edited by refack

   Contributor

   More actions

   It's still there in 269103a

   DEV D:\code\node>git rev-parse HEAD
   269103a0e5e30cc217bde1660087e87dfc722b8a
   
   DEV D:\code\node>msbuild /p:Configuration=Debug ...
   ...
   CustomBuild:
     generating: "Debug\obj\v8_snapshot\/embedded.S" "Debug\obj\v8_snapshot\/snapshot.cc"
     D:\bin\dev\vs\2019\CommunityPreview\VC\Tools\MSVC\14.20.27404\include\vector(170) : Assertion failed: vector iterators incompatible
   D:\bin\dev\vs\2019\CommunityPreview\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code -1073740791. [D:\code\node\deps\v8\gypfiles\v8_snapshot.vcxproj]
   Done Building Project "D:\code\node\deps\v8\gypfiles\v8_snapshot.vcxproj" (Build target(s)) -- FAILED.

   Reopening as #26685 is planned to land after V8 7.4 goes stable at 4/23.
5. refack

   reopened this on Mar 16, 2019
6. refack

   added

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.

   regressionIssues related to regressions.Issues related to regressions.

   on Mar 16, 2019
7. refack

   self-assigned this

   on Mar 16, 2019
8. refack

   added a commit that references this issue on Mar 17, 2019

   deps,v8: cherry-pick 385aa80

   ...

   8e308e8
9. refack

   closed this as completedin #26702on Mar 17, 2019
10. refack

    removed their assignment

    on Mar 17, 2019