Skip to content

Investigate flaky test-worker-prof #26401

Closed
#37372
Closed
Investigate flaky test-worker-prof#26401
#37372
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.workerIssues and PRs related to the worker_threads module and Worker API.

Description

@Trott
Trott
opened on Mar 2, 2019

https://ci.nodejs.org/job/node-test-binary-arm/6472/RUN_SUBSET=0,label=pi1-docker/console

test-requireio_ceejbot-debian9-armv6l_pi1p-1

00:34:22 not ok 365 parallel/test-worker-prof
00:34:22   ---
00:34:22   duration_ms: 19.977
00:34:22   severity: fail
00:34:22   exitcode: 1
00:34:22   stack: |-
00:34:22     assert.js:85
00:34:22       throw new AssertionError(obj);
00:34:22       ^
00:34:22     
00:34:22     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
00:34:22     
00:34:22     1 !== 2
00:34:22     
00:34:22         at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-worker-prof.js:29:8)
00:34:22         at Module._compile (internal/modules/cjs/loader.js:807:30)
00:34:22         at Object.Module._extensions..js (internal/modules/cjs/loader.js:818:10)
00:34:22         at Module.load (internal/modules/cjs/loader.js:674:32)
00:34:22         at tryModuleLoad (internal/modules/cjs/loader.js:606:12)
00:34:22         at Function.Module._load (internal/modules/cjs/loader.js:598:3)
00:34:22         at Function.Module.runMain (internal/modules/cjs/loader.js:870:12)
00:34:22         at internal/main/run_main_module.js:21:11
00:34:22   ...

Activity

  1. Trott
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    workerIssues and PRs related to the worker_threads module and Worker API.
    on Mar 2, 2019

  2. refack commented on Mar 10, 2019

    @refack
    refack
    on Mar 10, 2019
    Contributor

    https://ci.nodejs.org/job/node-test-binary-arm/6731/RUN_SUBSET=2,label=pi1-docker/testReport/junit/(root)/test/parallel_test_worker_prof/
    Worker: https://ci.nodejs.org/computer/test-requireio_davglass-debian9-armv6l_pi1p-1/

    mark-as-flaky PR: #26557

  3. gireeshpunathil commented on Mar 10, 2019

    @gireeshpunathil
    gireeshpunathil
    on Mar 10, 2019
    Member

    the assertion failure indicates that either the parent or the child - one those did not produce a trace output! (something beyond what we thought could potentially cause flake in this test - i.e., the process timings and the number of ticks etc.)

  4. refack
    added a commit that references this issue on Mar 10, 2019

    test: mark `test-worker-prof` as Flaky on ARM

    8d665c0

  5. refack commented on Mar 10, 2019

    @refack
    refack
    on Mar 10, 2019
    Contributor

    Now it's flaking on Windows
    Worker: https://ci.nodejs.org/computer/test-azure_msft-win10-x64-1/

    assert.js:340
    throw err;
    ^

AssertionError [ERR_ASSERTION]: 3 >= 15
    at Object.<anonymous> (c:\workspace\node-test-binary-windows\test\parallel\test-worker-prof.js:39:3)
    at Module._compile (internal/modules/cjs/loader.js:813:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:824:10)
    at Module.load (internal/modules/cjs/loader.js:680:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:612:12)
    at Function.Module._load (internal/modules/cjs/loader.js:604:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:876:12)
    at internal/main/run_main_module.js:21:11
  6. refack
    added
    windowsIssues and PRs related to the Windows platform.
    armIssues and PRs related to the ARM architecture.
    on Mar 10, 2019

  7. targos commented on Mar 11, 2019

    @targos
    targos
    on Mar 11, 2019
    Member

    Also on Linux without intl:

    https://ci.nodejs.org/job/node-test-commit-linux-containered/11274/nodes=ubuntu1604_sharedlibs_withoutintl_x64/testReport/junit/(root)/test/parallel_test_worker_prof/

    assert.js:340
    throw err;
    ^

AssertionError [ERR_ASSERTION]: 10 >= 15
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-worker-prof.js:39:3)
    at Module._compile (internal/modules/cjs/loader.js:813:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:824:10)
    at Module.load (internal/modules/cjs/loader.js:680:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:612:12)
    at Function.Module._load (internal/modules/cjs/loader.js:604:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:876:12)
    at internal/main/run_main_module.js:21:11
  8. refack
    added a commit that references this issue on Mar 12, 2019

    test: mark test-worker-prof as flake on all platforms

    e1cd8ac
  9. BridgeAR
    added 5 commits that reference this issue on Mar 13, 2019

    test: mark `test-worker-prof` as Flaky on ARM

    677c43d

    test: mark `test-worker-prof` as Flaky on ARM

    cc32461

    test: mark test-worker-prof as flake on all platforms

    300ad04

    test: mark `test-worker-prof` as Flaky on ARM

    bf78365

    test: mark test-worker-prof as flake on all platforms

    2c55282

  10. 131 remaining items

  11. Trott
    closed this as completedin 04fb597on Feb 20, 2021
  12. targos
    added a commit that references this issue on Feb 28, 2021

    test: fix flaky test-worker-prof

    d5c311e
  13. joyeecheung
    reopened this on Aug 21, 2023

  14. joyeecheung commented on Aug 21, 2023

    @joyeecheung
    joyeecheung
    on Aug 21, 2023
    Member

    Still flaky: nodejs/reliability#640

  15. joyeecheung commented on Aug 21, 2023

    @joyeecheung
    joyeecheung
    on Aug 21, 2023
    Member

    I start to wonder if we actually need 15 ticks in the tests. Maybe it's already good enough to run some tests and check the code-creation events...

  16. nodejs-github-bot
    added a commit that references this issue on Sep 4, 2023

    test: make test-worker-prof more robust

    7f001c2
  17. ruyadorno
    added a commit that references this issue on Sep 28, 2023

    test: make test-worker-prof more robust

    c3c6c4f

  18. shnooshnoo commented on Dec 12, 2023

    @shnooshnoo
    shnooshnoo
    on Dec 12, 2023

    I believe this issue can be closed now #37673 (comment)

  19. lpinca
    closed this as completedon Sep 10, 2024
  20. sjarmak
    added a commit that references this issue on Jul 27, 2026

    test: unmark test-worker-prof as flaky

    62e8cc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.workerIssues and PRs related to the worker_threads module and Worker API.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions