Repository navigation
TLS maxVersion not working #25267
Description
- Version: v10.15.0
- Platform: Windows 10 Home v10.0.14393 x64
- Subsystem: TLS
When using TLS.connect() the options are passed to TLS.createSecureContext().
TLS.createSecureContext() can take a maxVersion argument which specifies the maximum TLS version to allow, however this doesn't work.
The snippet below demonstrates that when you pass a maxVersion value of TLSv1 the connection succeeds even though the domain personal.natwest.com does not support TLS 1.0
const TLS = require("tls");
let options = {
port: 443,
host: "personal.natwest.com",
maxVersion: "TLSv1"
};
let socket = TLS.connect(options, () => {
console.log("Success");
socket.destroy();
}).on("error", (err) => {
console.log("Error");
socket.destroy();
});
Activity
ZYSzys commentedon Dec 29, 2018
TBH, The output is
Errorwhen I run the snippet above🤔.Trott commentedon Dec 29, 2018
minVersionandmaxVersionwere added in 11.4.0. So they will have no effect in 10.15.0.Trott commentedon Dec 29, 2018
minVersionandmaxVersionare being added to 10.x in #24979 but that version won't be out until March, if all goes according to plan.