Skip to content

Build failure on Windows #25096

Closed
Closed
Build failure on Windows#25096
Labels
moduleIssues and PRs related to the module subsystem.windowsIssues and PRs related to the Windows platform.

Description

@gabrielschulhof
gabrielschulhof
opened on Dec 17, 2018

While running vcbuild.bat test-addons:

Building addons
internal/modules/cjs/loader.js:602
    throw err;
    ^

Error: Cannot find module 'to-vfile'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:600:15)
    at Function.Module._load (internal/modules/cjs/loader.js:529:25)
    at Module.require (internal/modules/cjs/loader.js:654:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (C:\Users\agnes\code\node\tools\doc\addon-verify.js:11:15)
    at Module._compile (internal/modules/cjs/loader.js:718:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)
    at Module.load (internal/modules/cjs/loader.js:617:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)

Activity

  1. gabrielschulhof
    added
    moduleIssues and PRs related to the module subsystem.
    windowsIssues and PRs related to the Windows platform.
    on Dec 17, 2018

  2. Trott commented on Dec 18, 2018

    @Trott
    Trott
    on Dec 18, 2018
    Member

    @nodejs/build @nodejs/platform-windows

  3. bzoz commented on Dec 18, 2018

    @bzoz
    bzoz
    on Dec 18, 2018
    Contributor

    Can reproduce. Clean master checkout fails to build addons.

  4. bzoz
    added a commit that references this issue on Dec 18, 2018

    win, build: fix building addons on Windows

    64d5574

  5. bzoz commented on Dec 18, 2018

    @bzoz
    bzoz
    on Dec 18, 2018
    Contributor

    Fix in #25108

  6. gengjiawen commented on Dec 19, 2018

    @gengjiawen
    gengjiawen
    on Dec 19, 2018
    Member

    Any thought introduce appveyor to prevent future regression ?

  7. addaleax
    closed this as completedin 571273aon Dec 31, 2018
  8. targos
    added a commit that references this issue on Jan 1, 2019

    win, build: fix building addons on Windows

    2df0d14
  9. refack
    added a commit that references this issue on Jan 14, 2019

    win, build: fix building addons on Windows

    f23139f
  10. BethGriggs
    added a commit that references this issue on Apr 28, 2019

    win, build: fix building addons on Windows

    9af9ee5
  11. BethGriggs
    added a commit that references this issue on May 10, 2019

    win, build: fix building addons on Windows

    979a397
  12. MylesBorins
    added a commit that references this issue on May 16, 2019

    win, build: fix building addons on Windows

    91c4d28
  13. sjarmak
    added a commit that references this issue on Jul 27, 2026

    win, build: fix building addons on Windows

    571273a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    moduleIssues and PRs related to the module subsystem.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions