Skip to content

http/2 compat HEAD always finished #24743

Closed
Closed
http/2 compat HEAD always finished#24743
Labels
http2Issues and PRs related to the http2 subsystem.

Description

@ronag
ronag
opened on Nov 30, 2018

i.e. this breaks for HEAD requests:

server.on('request', (req, res) => {
  assert(!res.finished) // Fail
  res.end()
})

Activity

  1. ronag
    added a commit that references this issue on Feb 18, 2020

    http2: make compat finished match http/1

    8ba7a2f
  2. codebytere
    added a commit that references this issue on Feb 27, 2020

    http2: make compat finished match http/1

    9079bb4
  3. codebytere
    added 2 commits that reference this issue on Mar 15, 2020

    http2: make compat finished match http/1

    6aca5f9

    http2: make compat finished match http/1

    3a77c7e
  4. codebytere
    added a commit that references this issue on Mar 30, 2020

    http2: make compat finished match http/1

    76a0ba6
  5. jasnell
    added
    http2Issues and PRs related to the http2 subsystem.
    on Jun 26, 2020

  6. jasnell commented on Jun 26, 2020

    @jasnell
    jasnell
    on Jun 26, 2020
    Member

    @ronag is this still an issue?

  7. ronag commented on Jun 26, 2020

    @ronag
    ronag
    on Jun 26, 2020
    MemberAuthor

    I think this was fixed in #24347

  8. ronag
    closed this as completedon Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    http2Issues and PRs related to the http2 subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions