Skip to content

Make llhttp default HTTP parser #24730

Closed
Closed
Make llhttp default HTTP parser#24730
Assignees
addaleax

Description

@indutny
indutny
opened on Nov 29, 2018

Is your feature request related to a problem? Please describe.

Latest node.js can be compiled with --experimental-http-parser flag. Eventually, we'd want to swap things around and make it enable llhttp parser by default and hide http_parser under --legacy-http-parser flag.

Describe the solution you'd like

Hide http_parser under the flag when we're ready.

Describe alternatives you've considered

No alternatives.

Let's discuss the earliest version of Node that we're going to try this in. http_parser is a major component and it would take a lot of testing to make sure that llhttp is on the par with it quality-wise.

cc @nodejs/release @nodejs/lts

Activity

  1. indutny commented on Nov 29, 2018

    @indutny
    indutny
    on Nov 29, 2018
    MemberAuthor

    cc @nodejs/http

  2. joyeecheung commented on Nov 29, 2018

    @joyeecheung
    joyeecheung
    on Nov 29, 2018
    Member

    Is it possible to make it a runtime switch first? My impression is that it should be possible with some small C++ refactoring in the Parser class and make the decision when we get it from the binding based on the CLI option which should be available at that point

  3. rvagg commented on Nov 29, 2018

    @rvagg
    rvagg
    on Nov 29, 2018
    Member

    related: I'm working on a sharedlibs builder in CI that'll test llhttp builds on all 11+ CI runs, so we'll soon be essentially mandating stability and quality for llhttp in parallel. Only covers one platform of course.

  4. addaleax commented on Nov 30, 2018

    @addaleax
    addaleax
    on Nov 30, 2018
    Member

    @joyeecheung → #24739

  5. ofrobots commented on Nov 30, 2018

    @ofrobots
    ofrobots
    on Nov 30, 2018
    Contributor

    IMHO, we should make llhttp the default in Node 12. If we do not do so, we will have to maintain and fix security issues in both http_parser and llhttp until 12 goes EOL in April 2022 at the earliest.

    We will have 6 months of ecosystem testing available to us to harden llhttp before 12 goes LTS.

  6. addaleax
    added a commit that references this issue on Dec 4, 2018

    http: make parser choice a runtime flag

    3587d21
  7. addaleax
    self-assigned this
    on Dec 5, 2018
  8. danbev
    added a commit that references this issue on Dec 6, 2018

    http: make parser choice a runtime flag

    aa943d0
  9. addaleax
    added a commit that references this issue on Dec 6, 2018

    http: switch default parser to llhttp

    790300d
  10. BridgeAR
    added 3 commits that reference this issue on Dec 6, 2018

    http: make parser choice a runtime flag

    4296e73

    http: make parser choice a runtime flag

    c8d5e31

    http: make parser choice a runtime flag

    5ab22c8
  11. addaleax
    closed this as completedin 2cb8f24on Dec 9, 2018
  12. refack
    added 2 commits that reference this issue on Jan 14, 2019

    http: make parser choice a runtime flag

    dd48879

    http: switch default parser to llhttp

    a843199
  13. sjarmak
    added a commit that references this issue on Jul 27, 2026

    http: switch default parser to llhttp

    2cb8f24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions