You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
make test error - Error: Cannot find module '../../tools/eslint' #24579
Guys, I know this is a very old version but I would assume such old issue wouldn't show up again.
I am trying to install node.js 6.14 on a Ubuntu Server 18.04. Yes, I know it's a very old version of node.js, but the software I was asked to install relies on node.js 6.x :(
When I run 'make test' I get:
[ PASSED ] 38 tests.
make[1]: Leaving directory '/home/yucatan/node-v6.14.4'
/usr/bin/python2.7 tools/test.py --mode=release -J \
doctool inspector known_issues message pseudo-tty parallel sequential addons addons-napi
=== release test-eslint-lowercase-name-for-primitive ===
Path: parallel/test-eslint-lowercase-name-for-primitive
module.js:478
throw err;
^
Error: Cannot find module '../../tools/eslint'
at Function.Module._resolveFilename (module.js:476:15)
at Function.Module._load (module.js:424:25)
at Module.require (module.js:504:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (/home/yucatan/node-v6.14.4/test/parallel/test-eslint-lowercase-name-for-primitive.js:5:49)
at Module._compile (module.js:577:32)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
Command: out/Release/node /home/yucatan/node-v6.14.4/test/parallel/test-eslint-lowercase-name-for-primitive.js
=== release test-eslint-number-isnan ===
Path: parallel/test-eslint-number-isnan
module.js:478
throw err;
^
On later versions of Node.js we added code to the relevant tests to skip them if tools/eslint was missing (i.e. building from the src tarball): #20372
This hasn't been backported to 6.x (and would not now as 6.x is in maintenance).
Yes, I am buidling from the 6.14 tarball. I just don't get it. It needs eslint to proper test, but I can't build/install eslint if I don't have node/npm installed. I am lost on how to fix this :(
I'm going to close this as we're not going to go back and change the source tarball for that release. But if you continue to have questions/issues around this, feel free to keep commenting.
Activity
richardlau commentedon Nov 23, 2018
Are you building from the src tarball? IIRC we exclude
tools/eslintfrom that (it's there in the git tree).On later versions of Node.js we added code to the relevant tests to skip them if
tools/eslintwas missing (i.e. building from the src tarball): #20372This hasn't been backported to
6.x(and would not now as6.xis in maintenance).yucatan commentedon Nov 23, 2018
Yes, I am buidling from the 6.14 tarball. I just don't get it. It needs eslint to proper test, but I can't build/install eslint if I don't have node/npm installed. I am lost on how to fix this :(
richardlau commentedon Nov 23, 2018
@yucatan You could try building from the source code archives that GitHub creates (as opposed to the ones our release scripts build) from https://github.com/nodejs/node/releases/tag/v6.14.4 (e.g. https://github.com/nodejs/node/archive/v6.14.4.tar.gz).
Trott commentedon Nov 23, 2018
Another thing you can do to work around is remove line 127 (
$(MAKE) lint) from the Makefile.Or you can simply accept that the tests passed since linting is the last thing the tests do in that version of the Makefile.
Trott commentedon Nov 23, 2018
I'm going to close this as we're not going to go back and change the source tarball for that release. But if you continue to have questions/issues around this, feel free to keep commenting.