Repository navigation
repl: REPL history seems broken in master and v11.2.0 #24385
Description
- Version: v11.2.0, v12.0.0-nightly201811153212f77ac6 or 'v12.0.0-v8-canary20181115bc23a47c3b'
- Platform: Windows 7 x64
- Subsystem: repl
- Delete
.node_repl_history. - Launch
node. - Type:
> 1
1
- Look into
.node_repl_history, there is1there. - Type:
> 2
2
- Look into
.node_repl_history, there is only2. - Type:
> 3
3
- Look into
.node_repl_history, there is only3. - Type UP ARROW several times. There is only:
> 3
- Close
node. - Look into
.node_repl_history, there is only3there.
Can anybody reproduce?
Activity
[-]repl: REPL history seems broken in master[/-][+]repl: REPL history seems broken in master and v11.2.0[/+]vsemozhetbyt commentedon Nov 15, 2018
I cannot reproduce with v11.1.0.
I can reproduce with v11.2.0.
vsemozhetbyt commentedon Nov 15, 2018
cc @antsmartian as per possible cause #22153 backported in v11.2.0.
antsmartian commentedon Nov 16, 2018
@vsemozhetbyt 😢 Yes, thats what caused the regression. My bad.
antsmartian commentedon Nov 16, 2018
@vsemozhetbyt Working on a PR, on the way. Also, I guess we need to tighten our history test cases, as this should have been caught in first place :( :( .
repl: handle buffered string logic on finish
repl: handle buffered string logic on finish
repl: handle buffered string logic on finish
caub commentedon Dec 1, 2018
it's still broken in v11.3.0
vsemozhetbyt commentedon Dec 1, 2018
11.3.0 was a security concerning release, so as per the changelog the fix was not backported yet,
vsemozhetbyt commentedon Dec 1, 2018
The fix is on
v11.x-stagingbranch, so this may be fixed in the next 11 release.test: adding history regression test case
test: adding history regression test case
test: adding history regression test case
repl: handle buffered string logic on finish
test: adding history regression test case
test: adding history regression test case
test: adding history regression test case
test: adding history regression test case
RichardBronosky commentedon Apr 5, 2019
I install node via homebrew on macOS. Can someone please explain how I can get this fix?
caub commentedon Apr 5, 2019
update node
RichardBronosky commentedon Apr 5, 2019
I have
and I am still getting this behavior.
caub commentedon Apr 6, 2019
Oh, it might be a problem on macOS then, for me on v11.13.0 and linux, the problem doesn't exist anymore (it was fixed since v11.4.0 actually)
RichardBronosky commentedon Apr 14, 2019
I was having a near breakdown from stress and didn't notice the difference between v11.3.0 and v11.13.0. I had for former version and the issue before upgrading to the later but didn't notice the number change and thought I was on the latter from the start. I then went out and bought a OneWheel to burn off some stress.
Thanks for the help though!
repl: handle buffered string logic on finish