Repository navigation
Passing options object to http.createServer stops server responding #24105
Description
- Version: node 8.12.0
- Platform: macOS Sierra 10.12.6 (16G1510)
- uname -a: Darwin [USERNAME] 16.7.0 Darwin Kernel Version 16.7.0: [DATETIME]; root:xnu-3789.73.14~1/RELEASE_X86_64 x86_64
- Subsystem: http
Example:
"use strict";
const http = require('http');
const options = {};
const server = http.createServer(options, (req, res) => {
console.log('got here', req, res);
});
server.listen(4000);# telnet localhost 4000
GET /
Expected: Console.log of "got here"
Actual: No output.
It also doesn't work is options is set to:
const options = {
IncomingMessage: http.IncomingMessage,
ServerResponse: http.ServerResponse
}
Is working as expected in v10.13.0
Using node inspect the difference in execution between v8 and v10 seems to be this line:
_http_common.js:117
return parser.onIncoming(parser.incoming, shouldKeepAlive);
Which should be returning a IncomingMessage object, but instead returns nothing. But that's as far as I could get with this.
Calling without the options object - i.e.:
const server = http.createServer((req, res) => {})Works as expected
Activity
Trott commentedon Nov 6, 2018
@nodejs/http
oyyd commentedon Nov 9, 2018
node/doc/api/http.md
Lines 1779 to 1786 in bd8c107
In fact, The
optionsargument is added in v9.6.0 so that it don't passrequestListenertohttp.Serverin v8.12.0.brokencube commentedon Nov 9, 2018
Looks like it was backported for v8.12.0:
#21593
and from the Release notes from v8.12.0:
oyyd commentedon Nov 9, 2018
Yeah, but the code of
v8.x-stagingseems not:node/lib/http.js
Lines 33 to 35 in 26d145a
I'm not sure if I have missed something.
brokencube commentedon Nov 9, 2018
Ah, apparently the http change got backed out of the merge for v8.12.0: #20456 (comment)
apapirovski commentedon Nov 29, 2018
As expected given this is not a valid signature for that function.
brokencube commentedon Nov 29, 2018
Well there is still an issue here... either:
apapirovski commentedon Nov 29, 2018
@brokencube Thanks for an update. That's helpful in moving this forward. I'm going to reopen and assign the appropriate labels.
doc: fix http.createServer for versions before v9.6.0
aautio commentedon Dec 5, 2018
I've submitted #24856 as a fix for the documentation.Edit: I made the first pull request in a wrong branch. Here is a new one: #24869
doc: fix api documentation of http.createServer
MylesBorins commentedon Dec 10, 2018
landed in v8.x-staging