Skip to content

HTTP Client cleanup #2400

Closed
Closed
HTTP Client cleanup#2400
Labels
httpIssues and PRs related to the http subsystem.questionIssues asking questions about Node.js.

Description

@ronkorving
ronkorving
opened on Aug 16, 2015

Hi guys,

I'm working on some cleanup for the http client code, hoping to improve performance and maintainability. I have one question though. Why does the ClientRequest have an isArray check on options.headers? It seems like that is never the case.

It originated in nodejs/node-v0.x-archive@b09c588 by @creationix. I'm hoping there's someone around who could explain to me what the purpose of this test is (perhaps @creationix himself?).

Thank you.

Activity

  1. ChALkeR
    added
    questionIssues asking questions about Node.js.
    httpIssues and PRs related to the http subsystem.
    on Aug 16, 2015

  2. ChALkeR commented on Aug 16, 2015

    @ChALkeR
    ChALkeR
    on Aug 16, 2015
    Member

    See #1292 (wasn't merged).

  3. ronkorving commented on Aug 16, 2015

    @ronkorving
    ronkorving
    on Aug 16, 2015
    ContributorAuthor

    Thanks, that answers it.

  4. ronkorving
    closed this as completedon Aug 16, 2015

  5. ronkorving commented on Aug 16, 2015

    @ronkorving
    ronkorving
    on Aug 16, 2015
    ContributorAuthor

    I've left my comments there. I think the array behavior is broken and a solution (one of two) is warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    httpIssues and PRs related to the http subsystem.questionIssues asking questions about Node.js.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions