Repository navigation
dns.promises test coverage is poor #22471
Description
Ref: #20435 (comment)
Experimental dns/promises API is present in the current master without proper test coverage.
According to the coverage report, the following functions are not tested at all:
onlookuponlookupallonlookupservicecreateLookupServicePromise
While inspecting the experimental fs.promises, there were also some implementation bugs found that could have been caught by code coverage, see e.g. #20407. The dns.promises is much smaller in lines of code, but it is still possible that it contains bugs that could be noticed by extending coverage.
Activity
ChALkeR commentedon Aug 23, 2018
#21559 should partially (?) fix this, I presume.
SirR4T commentedon Aug 24, 2018
Willing to work towards this, with some mentoring/help. For example, would a
common.dnsTest()be helpful here, similar tocommon.fsTest()from #20439?sagitsofan commentedon Sep 10, 2018
@ChALkeR I will be happy to contribute in this issue.
Is there is an existing test file or should i create a new one (and if so - in which libary under "test"?)
Trott commentedon Sep 11, 2018
It's considerably less poor now that we run
internettests during coverage report generation. Right now, it's at 64 of 67 branches. Prior to that, it was 40 of 67.I'd welcome someone getting those last 3 branches covered, but I think this can nonetheless be closed at this time.
Trott commentedon Sep 18, 2018
I'm going to close this. Feel free to re-open if you think that's not warranted at this time, @ChALkeR.