Repository navigation
When worker thread throw an error, main thread recieves exit code 0 instead of 1 #21707
Description
- Version:
v10.6.0 - Platform:
Windows 64-bitLinux 29d0523d5d87 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 Linux(Alpine Linux on Docker)Linux 30e69b847957 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 GNU/Linux(Debian on Docker)
- Subsystem:
worker_threads
Reproduction code
const { Worker, isMainThread } = require('worker_threads');
if (isMainThread) {
const worker = new Worker(__filename);
worker.on('error', err => {
console.log(`Worker threw an error: ${err.message}`);
});
worker.on('exit', code => {
console.log(`Worker finished with exit code ${code}`);
});
} else {
throw new Error('error!');
}Expected output
Worker threw an error: error!
Worker finished with exit code 1
Actual output
Worker threw an error: error!
Worker finished with exit code 0
Activity
targos commentedon Jul 8, 2018
@nodejs/workers
addaleax commentedon Jul 8, 2018
I think it might be enough to set
process.exitCodeinfatalExceptioninlib/internal/worker.js?lundibundi commentedon Jul 8, 2018
I've been looking into this one and would like to work on it, is it okay?
workers: fix invalid exit code in parent upon uncaught exception
workers: fix invalid exit code in parent upon uncaught exception
workers: fix invalid exit code in parent upon uncaught exception