Repository navigation
Why http2session.socket.bufferSize is always zero? #21631
Description
- Version: v10.4.1
- Platform: macOS 10.13.5
- Subsystem: net,http2
I encountered a problem that I couldn't get expected bufferSize from http2session, http2session.socket.bufferSize is always zero.
Reproduce Code
I write a test similar to test-net-buffersize.js:
const assert = require('assert');
const http2 = require('http2');
const server = http2.createServer();
server.listen(0, () => {
const session = http2.connect(`http://localhost:${server.address().port}`);
const stream = session.request({ ':path': '/' }, { endStream: false });
for (let i = 1; i < 10; i++) {
assert(stream.writable);
stream.write('a');
assert.strictEqual(session.socket.bufferSize, i); // AssertionError
}
stream.close();
});Is it correct way to obtain bufferSize from http2 session? I need this value to throttle uploads like net.Socket do.
Activity
jasnell commentedon Aug 10, 2018
This is due to the special way that http2 sessions interact with the socket at the native (c++) layer rather than the javascript layer. The socket object's js interface is not used directly, and therefore the bufferSize is not set. We can investigate a way of enabling that.
jasnell commentedon Sep 21, 2018
@addaleax ... do you have any thoughts on how we could make
bufferSizework on a socket bound to an http2session?oyyd commentedon Oct 16, 2018
According to the
netmodule,bufferSizeis:node/lib/net.js
Line 518 in deaddd2
As
Http2SessionandHttp2Streamhave internally maintainedwriteQueueSizewhich is actuallykLastWriteQueueSize, I think, maybe we can makebufferSizework on http2 module itself.http2: add Http2Stream.bufferSize
http2: add Http2Stream.bufferSize
apapirovski commentedon Nov 29, 2018
The PR for this has landed so I believe we can close this.
http2: add Http2Stream.bufferSize