Promisify server.listen

Problem:

const server = app.listen();
console.log(`Server listening on: ${server.address().port}`)

can fail, as the server is created asynchronously and using the callback is not always practical/flexible

Proposal

either server.listenPromise(port), or even better, have server.listen(port) return a Promise if no callback is provided

Example

// .... 

const start = async () => {
    await config.load();
    await DB.connect(dbOptions);
    router(app);
    app.use((err, req, res, next) => { // error handler
        // ...
    });

    const server = http.createServer(app);
    // proposal:
    return server.listen(process.env.PORT || 3000); // if .listen would be a promise resolving to server
    // or await server.listen(...); return server; else

    // currently I have to do:
    // return new Promise((res, rej) => server.listen(process.env.PORT || 3000, err => err ? rej(err) : res()));

    // or using express's app.listen, which wraps createServer and listen:
    // return new Promise((res, rej) => app.listen(process.env.PORT || 3000, function (err) {
    //      if (err) return rej(err);
    //      res(this) // this is node's http Server
    // }));

    // using util.promisify doesn't look much better:
    // return promisify(server.listen).bind(server)(process.env.PORT || 3000);
    // or
    // return promisify(cb => server.listen(process.env.PORT || 3000, cb))();
};

then using it somewhere else:

start()
        .then(server => console.log(`Server listening on: ${server.address().port}`))
        .catch(err => {
           // ...
        });

Edit: I'll try to submit this request to express, and have a similar promise method near https://github.com/expressjs/express/blob/master/lib/application.js#L616-L619

Edit2: the discussion in expressjs/express#3675 has interesting details

From what i see here, there would never be a real .catch, since the callback is being forwarded to the Server.on('listening' event (except for two edge cases, you would still need server.on('error')). This tricks you into believing your callback is being called once the server.listen function has executed properly.

I can introduce a Promise return and start a PR if you like (as well as for Server.prototype.close and Server.prototype.getConnections), but I think this particular case needs more attention than a single promise return. 🤔

If so, should the returned Promise be conditional on the presence of a callback ? This could lead to some confusion, but then you might argue that we need that for retrocomp. 😄

I have been checking and experimenting with promisifying server.listen + server.close and server.getConnections. There are two options, the 'lie to the devs' and return a Promise.resolve() or a more real option that would wrap the "maybe" callback and return a Promise.

I can launch the PR if anyone is willing to read it and @node/collaborators think this is a good idea

@jsmrcaga

@jsmrcaga Sorry but I didn't really understand how what you proposed would look like

just adding here another concise way suggested by @bmeck a while ago

await { then(r, f) { server.on('listening', r); server.on('error', f); } };

But I still think a shortcut for this would be handy

@caub

@caub please forgive the naiveté, but is that a new fancy syntax capability for await or is that pseudo code?

@shellscape

@shellscape It’s the (existing) ability of await to handle any value after it that has a .then() method that behaves like the Promise.prototype.then() one. This might be a slightly better example:

> await ({ then(resolve) { resolve(42) } })
42

I’m not sure it’s the most readable style to use await with, though. 😄

@addaleax

@addaleax thanks! just learned something 😀

@caub

@caub I was pretty surprised, that util.promisfy needed to .bind() the scope :O

Otherwise, I am fine with promisify and bind, it does look ugly but it is better than nothing 👍

@MartinMuzatko

For the record thats an example that works (within an async function). As @MartinMuzatko pointed out, you need bind(), which is not quite obvious.

const server = https.createServer( options, handler );
const promise = util.promisify( server.listen.bind( server ) );
await promise( port, listen );

I'd too prefer that listen() would return a Promise whenever there isn't a callback provided.

For example the mongodb driver does this in a very nice way, which makes using it in async flow controls easy and compact.

PS: It would be cool if this would work with all asynchronous Node.js core library functions. If there isn't a callback, return a promise...

@axkibe

@axkibe: Using your code, listen is undefined though afterwards, I need a reference to it for calling close on app shutdown.

@jsmrcaga

@jsmrcaga Sorry but I didn't really understand how what you proposed would look like

just adding here another concise way suggested by @bmeck a while ago
await { then(r, f) { server.on('listening', r); server.on('error', f); } };
But I still think a shortcut for this would be handy

don't you need to unsubscribe from the 'error' when 'listening' is fired? and the opposite as well?

You can use the "once" helper from "events":

const { once } = require('events');
...
const server = app.listen();
await once(server, 'listening');

More lines but fewer characters than the above solution and no need to unsubscribe.

That said, I'd love to just write const server = await app.listen();

Edit: Use CJS instead of ESM.

@jsmrcaga

@jsmrcaga Sorry but I didn't really understand how what you proposed would look like
just adding here another concise way suggested by @bmeck a while ago
await { then(r, f) { server.on('listening', r); server.on('error', f); } };
But I still think a shortcut for this would be handy
don't you need to unsubscribe from the 'error' when 'listening' is fired? and the opposite as well?

How to use it? I really can't understand it.

Tried this without success, stays stuck on '0'.

const app = require('express')();

async function listen() {
  const server = app.listen(3000);
  console.log(0);
  const r = () => console.log(1);
  const f = () => console.log(2);

  await { then(r, f) { server.on('listening', r); server.on('error', f); } };
  console.log(3);
}

listen();

@SrBrahma I'm not sure your 'listening' event exists, I don't see it nor on the official docs Node 14.2 or the express v4 docs.

My advice is to:

const app = express();

function listen() {
    return new Promise((resolve, reject) => {
         app.listen(3000, (err) => {
            if(err) {  return reject(err); }
            return resolve();
        });
    });
}

listen().then().catch()

if you wish to use async/await:

await listen();
// the rest of your code

@silverwind

@silverwind the reason why it never rejects is that:

The last parameter callback will be added as a listener for the 'listening' event.
source: https://nodejs.org/api/net.html#serverlisten

i.e. it's never registered for the 'error' event. 😬

habemus const server = await app.listen(); ??

Any news on this issue?

bump

has anyone already sent a PR with the proposal..?

Instead of "bumping" which does nothing on github, I suggest if this is still an issue for you to create a new one. I'd have to investigate the current state of affairs on this, which I right now don't have the time/energy for.

Generally speaking tough, from my impression 5 years ago when this issue was made, the node team was rather distanced to Promises, reluctantly adding them, which made me go ehh.. you don't see this is the js future? .. this has definitely changed and they embrace promises nowadays, so another attempt might go better (in case this is still an issue, I dunno)

net: add experimental net/promises API

net: tie listen() signal to server lifetime, async-iterable Server

net: use throwIfAborted and improve server iteration example

net: add experimental net/promises API

Navigation Menu

Repository navigation

Promisify server.listen #21482

Problem:

Proposal

Example

21 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Promisify server.listen #21482

Description

Problem:

Proposal

Example

Activity

jsmrcaga commented on Aug 31, 2018

jsmrcaga commented on Sep 1, 2018

caub commented on Sep 13, 2018

shellscape commented on Oct 9, 2018

addaleax commented on Oct 9, 2018

shellscape commented on Oct 9, 2018

MartinMuzatko commented on Feb 15, 2019

axkibe commented on Apr 2, 2019

strarsis commented on Aug 30, 2019

stavalfi commented on Dec 10, 2019

webarnes commented on Jan 12, 2020

ftzi commented on May 8, 2020

jsmrcaga commented on May 8, 2020

21 remaining items

tompahoward commented on Feb 16, 2023

jrichardsz commented on Dec 12, 2023

mosoriorian commented on Jan 25, 2024

mpicardvolvo commented on Feb 28, 2024

drmaquino commented on Feb 28, 2024

axkibe commented on Feb 29, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions